Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20211201072718.3969011-1-vkoul@kernel.org>
References: <20211201072718.3969011-1-vkoul@kernel.org>
Subject: Re: [PATCH] spmi: pmic-arb: Add support for PMIC v7
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        David Dai <daidavid1@codeaurora.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Vinod Koul <vkoul@kernel.org>
To:     Linus Walleij <linus.walleij@linaro.org>,
        Vinod Koul <vkoul@kernel.org>
Date:   Thu, 02 Dec 2021 15:06:23 -0800
User-Agent: alot/0.9.1
Message-Id: <20211202230624.C05F3C00446@smtp.kernel.org>
Precedence: bulk

Quoting Vinod Koul (2021-11-30 23:27:18)
> @@ -1169,8 +1270,12 @@ static int spmi_pmic_arb_probe(struct platform_dev=
ice *pdev)
>         pmic_arb =3D spmi_controller_get_drvdata(ctrl);
>         pmic_arb->spmic =3D ctrl;
> =20
> +       /*
> +        * Don't use devm_ioremap_resource() as the resources are shared =
in
> +        * PMIC v7 onwards, so causing failure when mapping
> +        */
>         res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "core"=
);
> -       core =3D devm_ioremap_resource(&ctrl->dev, res);
> +       core =3D devm_ioremap(&ctrl->dev, res->start, resource_size(res));

What does this mean? We have two nodes in DT that have the same reg
properties? How does that work?

>         if (IS_ERR(core)) {
>                 err =3D PTR_ERR(core);
>                 goto err_put_ctrl;