Message-ID: <43da99eb-6279-bf7a-3039-3f59f14ceadc@gmail.com>
Date:   Thu, 2 Dec 2021 19:23:14 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v2] net: broadcom: Catch the Exception
Content-Language: en-US
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, rafal@milecki.pl,
        bcm-kernel-feedback-list@broadcom.com, davem@davemloft.net,
        kuba@kernel.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org, fw@strlen.de
References: <20211203030250.1512671-1-jiasheng@iscas.ac.cn>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <20211203030250.1512671-1-jiasheng@iscas.ac.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/2/2021 7:02 PM, Jiasheng Jiang wrote:
> The return value of dma_set_coherent_mask() is not always 0.
> To catch the exception in case that dma is not support the mask.
> 
> Fixes: 9d61d138ab30 ("net: broadcom: rename BCM4908 driver & update DT binding")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Can you come up with a better subject, maybe:

net: bcm4908: Handle dma_set_coherent_mask error codes

or something like that?

> ---
> Changelog
> 
> v1 -> v2
> 
> * Change 1. Correct the Fixes tags.
> * Change 2. CC Florian.
> ---
>   drivers/net/ethernet/broadcom/bcm4908_enet.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> index 02a569500234..376f81796a29 100644
> --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> @@ -708,7 +708,9 @@ static int bcm4908_enet_probe(struct platform_device *pdev)
>   
>   	enet->irq_tx = platform_get_irq_byname(pdev, "tx");
>   
> -	dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
> +	err = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
> +	if (err)
> +		return err;
>   
>   	err = bcm4908_enet_dma_alloc(enet);
>   	if (err)
> 

-- 
Florian