Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E305BC433F5 for ; Fri, 3 Dec 2021 07:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378836AbhLCHWY (ORCPT ); Fri, 3 Dec 2021 02:22:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243222AbhLCHWX (ORCPT ); Fri, 3 Dec 2021 02:22:23 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D214C06174A for ; Thu, 2 Dec 2021 23:19:00 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12A7861EB4 for ; Fri, 3 Dec 2021 07:19:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91B43C53FAD; Fri, 3 Dec 2021 07:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638515939; bh=QmeH0cSAwndwQ/gNv727qvVaI4uFqZ8k3R0fK10THR8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vK9xGNrCTxFIfoi6vCbd+vgK7cJN0ljmTuLpob0DiT8WhC74lwTJacqt/7JJX1OcZ 9zPCLIKvy7KcCHXWi6NxkQRAVy6v8OM1b2JJmZ2V7DTGz05MXWjowG5KElg6WxTrVU EsB5hVRl5k97RQ/YtuT8EKD68YjUJD+tBEw4W7L8= Date: Fri, 3 Dec 2021 08:18:55 +0100 From: Greg KH To: davidcomponentone@gmail.com Cc: TheSven73@gmail.com, dan.carpenter@oracle.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Yang Guang , Zeal Robot Subject: Re: [PATCH v3] staging: fieldbus: replace snprintf with sysfs_emit Message-ID: References: <36a8d3be94d3575656d08204228eaa921db64c03.1638493815.git.yang.guang5@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36a8d3be94d3575656d08204228eaa921db64c03.1638493815.git.yang.guang5@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 03, 2021 at 09:17:32AM +0800, davidcomponentone@gmail.com wrote: > From: Yang Guang Does not match the address you send this email from as reported many times to you. > > coccinelle report: > ./drivers/staging/fieldbus/dev_core.c:73:8-16: > WARNING: use scnprintf or sprintf > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > Reported-by: Zeal Robot Again, I have commented on the use of this many times already. I will not take this change until you at least discuss it with us. sorry, greg k-h