Subject: Re: Re: [PATCH v2 1/2] x86/cpu: Introduce x86_get_cpufreq_khz()
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     tglx@linutronix.de, pbonzini@redhat.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org
References: <20211201024650.88254-1-pizhenwei@bytedance.com>
 <20211201024650.88254-2-pizhenwei@bytedance.com>
 <20211202222514.GD16608@worktop.programming.kicks-ass.net>
From:   zhenwei pi <pizhenwei@bytedance.com>
Message-ID: <947de021-df91-9219-7378-8addc6f66612@bytedance.com>
Date:   Fri, 3 Dec 2021 15:34:04 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211202222514.GD16608@worktop.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/3/21 6:25 AM, Peter Zijlstra wrote:
> On Wed, Dec 01, 2021 at 10:46:49AM +0800, zhenwei pi wrote:
>> Wrapper function x86_get_cpufreq_khz() to get frequency on a x86
>> platform, hide detailed implementation from proc routine.
>>
>> Also export this function for the further use, a typical case is that
>> kvm module gets the frequency of the host and tell the guest side by
>> kvmclock.
> 
> This function was already complete crap, and now you want to export it,
> *WHY* ?!
> 
> What possible use does KVM have for this random number generator?
> 
A KVM guest overwrites the '.calibrate_tsc' and '.calibrate_cpu' if 
kvmclock is supported:

in function kvmclock_init(void) (linux/arch/x86/kernel/kvmclock.c)
	...
         x86_platform.calibrate_tsc = kvm_get_tsc_khz;
         x86_platform.calibrate_cpu = kvm_get_tsc_khz;
	...

And kvm_get_tsc_khz reads PV data from host side. Before guest reads 
this, KVM should writes the frequency into the PV data structure.

And the problem is that KVM gets tsc_khz directly without aperf/mperf 
detection. So user may gets different frequency(cat /proc/cpuinfo) from 
guest & host.

Or is that possible to export function 'aperfmperf_get_khz'?

-- 
zhenwei pi