Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA225C43217 for ; Fri, 3 Dec 2021 10:01:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379718AbhLCKEy (ORCPT ); Fri, 3 Dec 2021 05:04:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbhLCKEw (ORCPT ); Fri, 3 Dec 2021 05:04:52 -0500 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4248C06173E; Fri, 3 Dec 2021 02:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7VzeHH1mGZBLhu927mmWIPghqzXBo4WrF6VXfhzX2rk=; b=ipHVDH3frt8hI7ZeH4FeS34Kbj XFExnPypxIUKN5Zbk/3+PhFyAZoDb4/uITSCH6cWhHhDfTMdUHrD+hsd+QeNE2DGORoLvkEu091TA kEIoolbLbGov+1Qj3BIcapiXb/jAK1yOPbNyjt1k43vGHDhIJRTwqLUOSY0J+Hwgq1OLCGMJB3Gnk k2vkUh4jAoQcxXJafxr1YbAsTsK5ANXWXkrcuBp6Bvx2yxo1iHKA1T4Xmapd88IIUYIiQmSDLMVA1 4We6mQ9eUPlrwRJJRI7V9IDvXmdQMawGAE7aN9NzaSWx2WzJN9uoeWjhVGTaiNEX1DYwTQbiNif7E mIoQT78w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mt5N3-001yW0-5d; Fri, 03 Dec 2021 10:00:49 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 8C62730001C; Fri, 3 Dec 2021 11:00:47 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 761232B36B3AE; Fri, 3 Dec 2021 11:00:47 +0100 (CET) Date: Fri, 3 Dec 2021 11:00:47 +0100 From: Peter Zijlstra To: Alexander Lobakin Cc: linux-hardening@vger.kernel.org, x86@kernel.org, Jesse Brandeburg , Kristen Carlson Accardi , Kees Cook , Miklos Szeredi , Ard Biesheuvel , Tony Luck , Bruce Schlobohm , Jessica Yu , kernel test robot , Miroslav Benes , Evgenii Shatokhin , Jonathan Corbet , Masahiro Yamada , Michal Marek , Nick Desaulniers , Herbert Xu , "David S. Miller" , Thomas Gleixner , Will Deacon , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Arnd Bergmann , Josh Poimboeuf , Nathan Chancellor , Masami Hiramatsu , Marios Pomonis , Sami Tolvanen , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, live-patching@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v8 07/14] kallsyms: Hide layout Message-ID: References: <20211202223214.72888-1-alexandr.lobakin@intel.com> <20211202223214.72888-8-alexandr.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202223214.72888-8-alexandr.lobakin@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 02, 2021 at 11:32:07PM +0100, Alexander Lobakin wrote: > From: Kristen Carlson Accardi > > This patch makes /proc/kallsyms display in a random order, rather > than sorted by address in order to hide the newly randomized address > layout. Is there a reason to not always do this? That is, why are we keeping two copies of this code around? Less code is more better etc..