From:   Ronak Jain <ronakj@xilinx.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     Michal Simek <michals@xilinx.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rajan Vaja <RAJANV@xilinx.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        Sai Krishna Potthuri <lakshmis@xilinx.com>
Subject: RE: [PATCH v3 2/3] firmware: zynqmp: Add sysfs entry for runtime
 features
Thread-Topic: [PATCH v3 2/3] firmware: zynqmp: Add sysfs entry for runtime
 features
Thread-Index: AQHX6Ca7gAQ8jBtJtU2F9h4sMwR3MqwgfxWAgAALW0A=
Date:   Fri, 3 Dec 2021 10:17:42 +0000
Message-ID: <BYAPR02MB44884D1746D719EB47A96BD2A46A9@BYAPR02MB4488.namprd02.prod.outlook.com>
References: <20211203091814.15582-1-ronak.jain@xilinx.com>
 <20211203091814.15582-3-ronak.jain@xilinx.com> <YanigXDtuo7MpVg8@kroah.com>
In-Reply-To: <YanigXDtuo7MpVg8@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?28DPIp+dUzTh+oMEdwih5USGZ59lQHI/iV7LvyByOGY8wg1CNqD1jv6Xy1A/?=
 =?us-ascii?Q?MC0+bYXm7DdARjLITEsqYP+W0c6uSVGsU/Su3CaB0voLRo1JyNR8c+c1IuuX?=
 =?us-ascii?Q?lpeYYr27G7RFYZNrPKkL0YyKtynSemZOt+VkNo8biC/FQzmmIfXToh0H3oak?=
 =?us-ascii?Q?1hJWLQb38TEn4vZvsbdZqHfJoQG8Dgft4k39TgG7G2GizR/C/xprnN4zDbVt?=
 =?us-ascii?Q?LA0ePXwKlqPCj3OApDEZ1NG210CnxCEw/uNIQXxVfVv+KacAtzfEWSC6hl7j?=
 =?us-ascii?Q?lV6984IC2zUSFJjrYSa5wzmb+WtKNBrywUTtwhI1nIpZsagO2DE7vKEi8oi3?=
 =?us-ascii?Q?j2qLsqO/INOdcmBfWleNOhulJlx9oLPJWT/EGNmeXKlZJWhiiEDsiIZ3pwiU?=
 =?us-ascii?Q?vGjybXwCLTzfLfCf2jJNTtwuuMDOLjkm9IGYF/AGlDmLKZLI0rrDNAOJgl6o?=
 =?us-ascii?Q?6cLhmXcpNWmP8PaWR+Su8GT02N0KJi+OuXItpZKZvs6wIevWaTHAM7eoJZmx?=
 =?us-ascii?Q?afldzeRQQ0iI4bSa9qKptdQo2LG67FkvxVrvZJPN0stIkXEYX1xx9fsrjIfx?=
 =?us-ascii?Q?WOPD1KFvzBGeUC0fBY7/WQbNadXGBim02JbsLc+4qDxztB59m4UfVihh9b11?=
 =?us-ascii?Q?6QuLnTOEGKtPDSEbVCXW+wVnappZnFQV8UUwUPdW7LWW8iCO659wn8cpxdoM?=
 =?us-ascii?Q?cqyZZE+7ulbUHDiiI1411YBRttfrjgtgPZFRL4QqEEo3W8ILy0b3FVhM16ve?=
 =?us-ascii?Q?OLKi/VOAxFIrcCsTmr1uHjTj3fOjlr10FSnj6y3k/O1PF2wuUNrnDvtDfrEY?=
 =?us-ascii?Q?/Whfoxy2IDBh/qlGksAtv8T+GvI8wGz0QyIvGbvlUJk77tzEaXcxan3jxhrp?=
 =?us-ascii?Q?unTKwE3TU9PNx3IbUIdhe7c6s00CyqE29s6TjuWiR2bdPxAqVvBikd/Gl5cW?=
 =?us-ascii?Q?mHS0bwdbBBvALhegGRrD8We0AqNvXypN6zxrLh5hBI+9Jtb2R+pUTDkkWBdE?=
 =?us-ascii?Q?cv0uoobO0B3dOszAeESnI7pY102MSO7jQaCGQA0WqWTubw16l7XsSv05tbCX?=
 =?us-ascii?Q?5r0mgtFVmL0z1pwlEH+hHlnTT7SGVM6lHD8BpR1FHdYqlCJrLnIkxTkx68ay?=
 =?us-ascii?Q?BSA3W+MhxiW20FtRy1vhPkItf83xQGqYSZPsRuYDXeJ9nvfschvQ7SseWNSR?=
 =?us-ascii?Q?4/Qih1i63sMfU3xk7cxNpjj5Lkvz4S4e6KQZLCDVhdVg2pKzsEO9E30mqL+n?=
 =?us-ascii?Q?/l+EOQw/KH9H2A86m7fYnAy0YDJkoLyrNcu6SpMz0aiMb1wh5Zui2BR32KdL?=
 =?us-ascii?Q?yBKgIe2ON2kr0y+F7ssikgtlRlXZNs4/uhsfiyMdFG2zIYnc03EcgMOHTaWq?=
 =?us-ascii?Q?/VYU+NPFDpWVImPBj1ILoelMQIIC7SLPUkRvSw1vnmHsyddw7HrG+uyZ01C5?=
 =?us-ascii?Q?gJwuAl3Xr1Xdz/uUcOgOegzb3tsM/DU1wDlotrPS5y76MIIJkYgLK0njMJ+f?=
 =?us-ascii?Q?s+6p/GPDXZCXeK6LL3ryWkEWDc/T0GRLx0MzL9AlwY4uTnnh4xJCn3mm9A3b?=
 =?us-ascii?Q?QPA+aSnL+tJgN2FNLNxSgo2Ggx1pA/9LvpeOeLxACSCtrO6yH0OPcV33ilpC?=
 =?us-ascii?Q?WQBI8CCVFlMGHxDBKSLnE6U=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR02MB4488.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0eaf917-d414-4bfc-2c4e-08d9b6462443
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2021 10:17:42.0674
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QHzAyZyEqoTBkPOhDfqPrxvqLMWKRCen6JnrtLNiLb6HLv2vDVjWXi1O3WOtBhCGVh4oZvASiAKgawDzjPT6Hg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB4342
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

Thanks for reviewing the patch.

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Friday, December 3, 2021 2:55 PM
> To: Ronak Jain <ronakj@xilinx.com>
> Cc: Michal Simek <michals@xilinx.com>; linux-kernel@vger.kernel.org; Raja=
n
> Vaja <RAJANV@xilinx.com>; corbet@lwn.net; linux-arm-
> kernel@lists.infradead.org; arnd@arndb.de; Sai Krishna Potthuri
> <lakshmis@xilinx.com>
> Subject: Re: [PATCH v3 2/3] firmware: zynqmp: Add sysfs entry for runtime
> features
>=20
> On Fri, Dec 03, 2021 at 01:18:13AM -0800, Ronak Jain wrote:
> > Create sysfs entry for runtime feature configuration. The support  is
> > added for an over temperature and external watchdog feature.
> >
> > The below listed files are used for runtime features configuration:
> > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_id
> > /sys/devices/platform/firmware\:zynqmp-firmware/feature_config_value
> >
> > In order to configure an over temperature or external watchdog
> > features, first the user need to select the valid config id and then
> > the user can configure the value for selected feature config id.
> >
> > Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
>=20
> Ah, here's the documentation.
>=20
> You should say so in the Subject line, and the changelog text is not corr=
ect, this
> is a documentation update.
I will fix the suggested changes.

>=20
>=20
> > ---
> > Changes in v3:
> > - None
> >
> > Changes in v2:
> > - Update commit message
> > ---
> >  .../ABI/stable/sysfs-driver-firmware-zynqmp   | 84 +++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >
> > diff --git a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> > b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> > index f5724bb5b462..2fde354715a5 100644
> > --- a/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> > +++ b/Documentation/ABI/stable/sysfs-driver-firmware-zynqmp
> > @@ -113,3 +113,87 @@ Description:
> >  		    # echo 0 >
> > /sys/devices/platform/firmware\:zynqmp-firmware/health_status
> >
> >  Users:		Xilinx
> > +
> > +What:		/sys/devices/platform/firmware\:zynqmp-
> firmware/feature_config_*
> > +Date:		Aug 2021
> > +KernelVersion:	5.14
>=20
> 5.14?
Will fix it.
>=20
> Are these sysfs files already in the kernel tree?
No
>=20
> And can you break this up into one entry per sysfs file?
>=20
> One for the feature_config_id file and one for feature_config_value?
Yes, I will make a separate documentation for the sysfs files.

Thanks,
Ronak
>=20
> thanks,
>=20
> greg k-h