Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Subject: Re: [PATCH 1/1] riscv: dts: fu740: Add PDMA node
From:   Jessica Clarke <jrtc27@jrtc27.com>
In-Reply-To: <20211203095744.1717706-2-v.v.mitrofanov@yadro.com>
Date:   Fri, 3 Dec 2021 10:50:46 +0000
Cc:     Rob Herring <robh+dt@kernel.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        David Abdurachmanov <david.abdurachmanov@sifive.com>,
        Yash Shah <yash.shah@sifive.com>,
        Atish Patra <atish.patra@wdc.com>,
        Greentime Hu <greentime.hu@sifive.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <DC14F9FB-D4E8-48DC-958A-CFEF2115F803@jrtc27.com>
References: <20211203095744.1717706-1-v.v.mitrofanov@yadro.com>
 <20211203095744.1717706-2-v.v.mitrofanov@yadro.com>
To:     "v.v.mitrofanov" <v.v.mitrofanov@yadro.com>
Precedence: bulk

On 3 Dec 2021, at 09:57, v.v.mitrofanov <v.v.mitrofanov@yadro.com> =
wrote:
>=20
> HiFive unmatched supports PDMA but is not implemented in DT.
>=20
> Add the PDMA node in SiFive FU740 soc-specific DT file.
>=20
> Signed-off-by: v.v.mitrofanov <v.v.mitrofanov@yadro.com>
> ---
> arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>=20
> diff --git a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi =
b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> index 64ff2e758336..833fb4f4376b 100644
> --- a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> +++ b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> @@ -164,6 +164,13 @@ prci: clock-controller@10000000 {
> 			#clock-cells =3D <1>;
> 			#reset-cells =3D <1>;
> 		};
> +		dma: dma@3000000 {
> +			compatible =3D "sifive,fu540-c000-pdma";

I know the PLIC and CGEM devices abuse fu540-specific compatible
strings (which it would be great to fix; FreeBSD is already prepared
for that, though it=E2=80=99d also be nice to introduce a generic =
compatible
string for the SiFive CGEM rather than having just a SoC-specific one
given the FU540 and FU740 have the same interface), but let=E2=80=99s =
not make
things worse. This should say fu740, and there should also be a generic
SiFive PDMA compatible so we don=E2=80=99t need to add a new compatible =
to an
otherwise-unchanged driver every time a new SiFive SoC appears.

Jess