Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F52C4332F for ; Fri, 3 Dec 2021 11:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380266AbhLCLKo (ORCPT ); Fri, 3 Dec 2021 06:10:44 -0500 Received: from mga11.intel.com ([192.55.52.93]:63165 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380216AbhLCLKn (ORCPT ); Fri, 3 Dec 2021 06:10:43 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="234465547" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="234465547" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 03:07:19 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="610360764" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 03:07:16 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mt6OL-001jtE-Pq; Fri, 03 Dec 2021 13:06:13 +0200 Date: Fri, 3 Dec 2021 13:06:13 +0200 From: Andy Shevchenko To: Stefan Binding Cc: Mark Brown , "Rafael J . Wysocki" , Len Brown , Hans de Goede , Mark Gross , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, patches@opensource.cirrus.com, Lucas Tanure Subject: Re: [PATCH 1/3] spi: Revert "spi: Remove unused function spi_busnum_to_master()" Message-ID: References: <20211202162421.7628-1-sbinding@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211202162421.7628-1-sbinding@opensource.cirrus.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 02, 2021 at 04:24:19PM +0000, Stefan Binding wrote: > From: Lucas Tanure > > Revert commit bdc7ca008e1f ("spi: Remove unused function > spi_busnum_to_master()") > This function is needed for the spi version of i2c multi > instantiate driver. I understand the intention, but I have no clue from this series (it lacks of proper cover letter, it lacks of much better and justified commit message in the patch 3) what is the actual issue. Without these to be provided it's no go for the series. Please, provide much better description what is the actual issue you are trying to solve (from patch 3 my guts telling me that this can be achieved differently without this code being involved). -- With Best Regards, Andy Shevchenko