Subject: Re: [PATCH net-next 07/11] net: hns3: add void before function which
 don't receive ret
To:     Leon Romanovsky <leon@kernel.org>
CC:     <davem@davemloft.net>, <kuba@kernel.org>, <wangjie125@huawei.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lipeng321@huawei.com>, <chenhao288@hisilicon.com>
References: <20211203092059.24947-1-huangguangbin2@huawei.com>
 <20211203092059.24947-8-huangguangbin2@huawei.com> <Yan8VDXC0BtBRVGz@unreal>
From:   "huangguangbin (A)" <huangguangbin2@huawei.com>
Message-ID: <73861dd7-e766-f39f-1244-91012bf03983@huawei.com>
Date:   Fri, 3 Dec 2021 19:27:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <Yan8VDXC0BtBRVGz@unreal>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021/12/3 19:15, Leon Romanovsky wrote:
> On Fri, Dec 03, 2021 at 05:20:55PM +0800, Guangbin Huang wrote:
>> From: Hao Chen <chenhao288@hisilicon.com>
>>
>> Add void before function which don't receive ret to improve code
>> readability.
>>
>> Signed-off-by: Hao Chen <chenhao288@hisilicon.com>
>> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c   | 2 +-
>>   drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_devlink.c | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> NAK,
> 
> Please stop to do it and fix your static analyzer.
> https://lore.kernel.org/linux-rdma/20211119172830.GL876299@ziepe.ca/
> 
> We don't add (void) in the kernel and especially for the functions that
> already declared as void.
> 
>     void devlink_register(struct devlink *devlink)
> 
> Thanks
> 
Ok, I remove this patch.
Thanks