From:   Yihao Han <hanyihao@vivo.com>
To:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] scsi: pmcraid: Replace snprintf in show functions with sysfs_emit
Date:   Fri,  3 Dec 2021 03:51:58 -0800
Message-Id: <20211203115158.6022-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Et3QULSHEOlxKKDBTKll27e++/N0XvU5dpYUOzq/7Kn5hwDlYmVYhGEE8Oxk?=
 =?us-ascii?Q?POn3gn70ZVi9kd0RHey1sonjTh8BpkYll3vguYKRrSD45XrsVccILHzSdHhV?=
 =?us-ascii?Q?wmyqx2yZMZTp91jf9NkhTjgXYd0VoMou1EN0ARzOPU9K/2txrXIhuFHm9wNv?=
 =?us-ascii?Q?Zu3U2MSdMgQgn5NBZJvLFmvCOpaN3iiQYunIlaybiM1wM6ev+JvEXSOYiRY5?=
 =?us-ascii?Q?N9XDEbDRonf73b2Q3VzsZNgN3wfH7CuvsViYHPk11PFyqI41fse2OiE0a9SK?=
 =?us-ascii?Q?Z2SnIoU5T2i9QbY6MlKAkZ5wFExQwBx9L6+Jwk/NfnSed5QD2BdAVbnCxcty?=
 =?us-ascii?Q?MmKIe22gDN0L3YT+wV3MXzWKsWy/TlsS+B+o+vTTgGa0KcENf0UzBEukFHi1?=
 =?us-ascii?Q?0mPfO1NXILbCBCvHrQt/DPUnO58DuaxGoNzN4xoH0rw5SKCeEditn3EryLNa?=
 =?us-ascii?Q?4JoCMljLss8Ce4uMIkZ79jRZz35PQ2EgVAbvXNtXhXuICi9Xal+PdP3oB8Ng?=
 =?us-ascii?Q?xgttRTCbomIxhgv9rwQtXnuqa0+soovX7+Hb3aLqr7ROjOUzbl/gvaHgQQJA?=
 =?us-ascii?Q?8Ft2z4XGpqYcq5QATwoGzGZak4SG5UL2S5ATdpyIwbl5MbzOhVCNIzVK+1Mo?=
 =?us-ascii?Q?s3eu/mJoGZKA9TwA3Tkv+V2Rbb+WLRIWP+aZIZrdm1jmRVnhElv4wHxNCLoZ?=
 =?us-ascii?Q?w6Wdj1RlkIt3KC+UkQKkvFCPVTo9mTI/9l+DIwS7y+b+qtxzl7/+Q12N3rRB?=
 =?us-ascii?Q?GgZZQxsX04TS4q/l45xGPndMqTmIQUfGnLquRAW7sgEqeP8XRCkkTeg4yeub?=
 =?us-ascii?Q?D0IZ+fHAdl3mewJla6bLQbRA/iW27DaAl9zTenosi2ELmzV0xd5ExunN92wo?=
 =?us-ascii?Q?VOplJ/Ip+dShj+yESfT2c89IVEBp5+WDeBg8rIubPisodyBUnm9l8I0xwK62?=
 =?us-ascii?Q?8Ng5OF1I2potjpWh67oWeOPZ76icGcpvm44WCKwh8g5jlVuUztG6jcxjJury?=
 =?us-ascii?Q?8vupvKbjpEJWs4nw7VcAoSZSz9lypnqV9qRxRfY3aEeghNiwF+1WNdcNJ9Qi?=
 =?us-ascii?Q?naMIe6GsB/KxVOWRe1JTgl7atVKAwPWz4VIN8OBSqQhPwBFATvvAkSt3JW1l?=
 =?us-ascii?Q?dmSbBJIUZ877S2f2XyQ1SAGuRaYGJGVWoy2WuBARhPCm3n+xGTqBGc3NiVMn?=
 =?us-ascii?Q?bdJMH/maGGnucg79wX8t/A84pLsuvd3u4c9A/WEsVwdjTYZytM4GrBYpuN6s?=
 =?us-ascii?Q?CMjD87u1WtXZn/VIGgaAuCEMMgEbKllW0mGGBYnNYWYRugzIujYyPt3xmkuf?=
 =?us-ascii?Q?acYXhXpWg6GQRyX8TtTx8ydpgm+8cdas5UZZqGXWhjWxIzmQ8wcA6EmIriA2?=
 =?us-ascii?Q?24moMljYEfOog6P+kI1jdBIYk+L3u7vhiX9EqB/KamXFbE7Fco3FKGJb+PMN?=
 =?us-ascii?Q?/9L5qY+5nJkPsDcVwxgDJtI59+Sz7VqRckobM0VKq8l9mbc2M153nZzY+/Iu?=
 =?us-ascii?Q?MldOwg8v2/SiuK6dCf56q96EHQqD+9RPOgiQgX7CCOOkWCHT/tsw0wGfAk3t?=
 =?us-ascii?Q?WXyDM58sVMYlKs/9wcspnS11O0rCiy0je+8kFCzyOxupykI47MtEIbmh1pnM?=
 =?us-ascii?Q?tOuJm2WbAg6q9mgA6E0z8yM=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 115e682f-2c15-4597-dbff-08d9b65356e9
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 11:52:10.7806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hbkOe7IecyIDUbz7iNle+VET0fxan6Txj9Nmr6XSFiByl8AJk+AtfXC/EOXzCgp7pKT4WqpGXuX2tJwaGXez7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2894
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/scsi/pmcraid.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 2fe7a0019fff..551713d33838 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -3984,7 +3984,7 @@ static ssize_t pmcraid_show_log_level(
 	struct Scsi_Host *shost = class_to_shost(dev);
 	struct pmcraid_instance *pinstance =
 		(struct pmcraid_instance *)shost->hostdata;
-	return snprintf(buf, PAGE_SIZE, "%d\n", pinstance->current_log_level);
+	return sysfs_emit(buf, "%d\n", pinstance->current_log_level);
 }
 
 /**
@@ -4045,7 +4045,7 @@ static ssize_t pmcraid_show_drv_version(
 	char *buf
 )
 {
-	return snprintf(buf, PAGE_SIZE, "version: %s\n",
+	return sysfs_emit(buf, "version: %s\n",
 			PMCRAID_DRIVER_VERSION);
 }
 
@@ -4079,7 +4079,7 @@ static ssize_t pmcraid_show_adapter_id(
 		pinstance->pdev->devfn;
 	u32 aen_group = pmcraid_event_family.id;
 
-	return snprintf(buf, PAGE_SIZE,
+	return sysfs_emit(buf,
 			"adapter id: %d\nminor: %d\naen group: %d\n",
 			adapter_id, MINOR(pinstance->cdev.dev), aen_group);
 }
-- 
2.17.1