Sender: charante=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org CDF66C4360D
Subject: Re: [PATCH v2] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for
 shmem
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Charan Teja Reddy <quic_charante@quicinc.com>, hughd@google.com,
        akpm@linux-foundation.org, vbabka@suse.cz, rientjes@google.com,
        david@redhat.com, mhocko@suse.com, surenb@google.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <1638442253-1591-1-git-send-email-quic_charante@quicinc.com>
 <YajJqY2ByC8uwa46@casper.infradead.org>
 <a88a3708-cdb6-589c-5828-0a4721c683d7@codeaurora.org>
 <YajsJSejHlx8n11U@casper.infradead.org>
From:   Charan Teja Kalla <charante@codeaurora.org>
Message-ID: <04ca54ad-0e03-84b1-bf5c-131a582137d4@codeaurora.org>
Date:   Fri, 3 Dec 2021 17:25:40 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <YajsJSejHlx8n11U@casper.infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

()

On 12/2/2021 9:24 PM, Matthew Wilcox wrote:
> Would this change to the documentation have prevented you from making
> this mistake?
> 
>  The advanced API is based around the xa_state.  This is an opaque data
>  structure which you declare on the stack using the XA_STATE()
>  macro.  This macro initialises the xa_state ready to start walking
>  around the XArray.  It is used as a cursor to maintain the position
>  in the XArray and let you compose various operations together without
> -having to restart from the top every time.
> +having to restart from the top every time.  The contents of the xa_state
> +are protected by the rcu_read_lock() or the xas_lock().  If you need to
> +drop whichever of those locks is protecting your state and tree, you must
> +call xas_pause() so that future calls do not rely on the parts of the
> +state which were left unprotected.

Yes, this looks much clear to me.

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project