Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D4AC43217 for ; Fri, 3 Dec 2021 12:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380789AbhLCMaM (ORCPT ); Fri, 3 Dec 2021 07:30:12 -0500 Received: from mga04.intel.com ([192.55.52.120]:8019 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236481AbhLCMaK (ORCPT ); Fri, 3 Dec 2021 07:30:10 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10186"; a="235700117" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="235700117" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:46 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="678082863" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 04:26:35 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mt7d5-001lPG-5I; Fri, 03 Dec 2021 14:25:31 +0200 Date: Fri, 3 Dec 2021 14:25:30 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Marc Zyngier , Matti Vaittinen , Sergio Paracuellos , Chunyan Zhang , Baruch Siach , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Tony Lindgren , Nicolas Saenz Julienne , Linus Walleij , Jianqun Xu , Alexandru Ardelean , Thierry Reding , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , patches@opensource.cirrus.com, bcm-kernel-feedback-list , linux-power , Linux ARM , "moderated list:ARM/Mediatek SoC..." , linux-pwm@vger.kernel.org, Linux-OMAP , linux-unisoc@lists.infradead.org, "open list:ARM/Rockchip SoC..." , linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, Ray Jui , Florian Fainelli , Scott Branden , Gregory Fong , Eugeniy Paltsev , Keerthy , Orson Zhai , Baolin Wang , Chunyan Zhang , Vladimir Zapolskiy , Matthias Brugger , Thierry Reding , Lee Jones , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , Robert Jarzmik , Manivannan Sadhasivam , Heiko Stuebner , Ludovic Desroches , Maxime Coquelin , Alexandre Torgue , Jonathan Hunter Subject: Re: [PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in the drivers Message-ID: References: <20211202210839.79140-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 03, 2021 at 09:40:55AM +0100, Bartosz Golaszewski wrote: > On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko > wrote: > > > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > > > Signed-off-by: Andy Shevchenko > > --- > > I have a bad feeling about this but I've gone through the drivers in > this patch and it seems like you don't update any of the drivers that > use multiple child OF nodes so I can't really point out any obvious > bug. Yes, like I said it's just a series to kick off the conversion. I left the corner cases to the last. > I have another change I'm working on that's related, let me send it shortly. Do you mean it should be attached to the series? -- With Best Regards, Andy Shevchenko