Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20211202210335.78015-1-andriy.shevchenko@linux.intel.com>
References: <20211202210335.78015-1-andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment
From:   Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc:     Niklas =?utf-8?q?S=C3=B6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jacopo Mondi <jacopo+renesas@jmondi.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Date:   Fri, 03 Dec 2021 13:09:19 +0000
Message-ID: <163853695964.3059017.11079601755830736700@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Andy Shevchenko (2021-12-02 21:03:35)
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.
>=20
> For the details one may look into the of_gpio_dev_init() implementation.

I see it.

Thanks,

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/i2c/max9286.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index 7c663fd587bb..a662d3aa0641 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1055,7 +1055,6 @@ static int max9286_register_gpio(struct max9286_pri=
v *priv)
>         gpio->label =3D dev_name(dev);
>         gpio->parent =3D dev;
>         gpio->owner =3D THIS_MODULE;
> -       gpio->of_node =3D dev->of_node;
>         gpio->ngpio =3D 2;
>         gpio->base =3D -1;
>         gpio->set =3D max9286_gpio_set;
> --=20
> 2.33.0
>