Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Envelope-to: herbert@gondor.apana.org.au,
 davem@davemloft.net,
 linux-crypto@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 robh+dt@kernel.org,
 devicetree@vger.kernel.org
Message-ID: <6887f803-f929-a483-c15d-759ec345e219@xilinx.com>
Date:   Fri, 3 Dec 2021 14:21:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [RFC PATCH 4/6] arm64: dts: zynqmp: Add Xilinx SHA3 node
Content-Language: en-US
To:     Harsha <harsha.harsha@xilinx.com>, <herbert@gondor.apana.org.au>,
        <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <michal.simek@xilinx.com>,
        <linux-arm-kernel@lists.infradead.org>, <robh+dt@kernel.org>,
        <devicetree@vger.kernel.org>
CC:     <saratcha@xilinx.com>, <harshj@xilinx.com>
References: <1638213623-32613-1-git-send-email-harsha.harsha@xilinx.com>
 <1638213623-32613-5-git-send-email-harsha.harsha@xilinx.com>
From:   Michal Simek <michal.simek@xilinx.com>
In-Reply-To: <1638213623-32613-5-git-send-email-harsha.harsha@xilinx.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 13:21:40.9001
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fda94a1-53ed-44a8-da4c-08d9b65fd7ec
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT007.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB3684
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/29/21 20:20, Harsha wrote:
> This patch adds a SHA3 DT node for Xilinx ZynqMP SoC.
> 
> Signed-off-by: Harsha <harsha.harsha@xilinx.com>
> ---
>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 74e6644..33b7ef6 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -174,6 +174,10 @@
>   				compatible = "xlnx,zynqmp-aes";
>   			};
>   
> +			xlnx_sha3_384: sha384 {
> +				compatible = "xlnx,zynqmp-sha3-384";
> +			};
> +
>   			zynqmp_reset: reset-controller {
>   				compatible = "xlnx,zynqmp-reset";
>   				#reset-cells = <1>;
> 

I will let Rob to comment this but I think this can be discovered and 
there is no need to link it with any device now. That's why maybe the 
whole dt binding is not needed at all.

Thanks,
Michal