Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB39C433F5 for ; Fri, 3 Dec 2021 13:29:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352257AbhLCNc0 (ORCPT ); Fri, 3 Dec 2021 08:32:26 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:53528 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352186AbhLCNcH (ORCPT ); Fri, 3 Dec 2021 08:32:07 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1A37B62A81 for ; Fri, 3 Dec 2021 13:28:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2A5DC53FAD; Fri, 3 Dec 2021 13:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638538122; bh=NwJ1lhqF2Aj0siD8FXO/9LVapPv2s9vz7saNe9OMvj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WIdIeXTnMoFZZBiL+O94Z5zo137xnEFxJaHhlEin0Fbt4fl98kTVIXRuJ1ad/4MxO cZuJ+hT4GqsVyZ6mJ2+/cPW1zQ3qK4Gfh+csF7kQWovxMEE9rsyiFPTeomLzorXUsm ZAix8aAIRUgiC37luZYvuZWCs0v7A5ZJSJX2okBg= Date: Fri, 3 Dec 2021 14:28:40 +0100 From: Greg KH To: Carlos Bilbao Cc: Linux Kernel Mailing List , Catalin Marinas , Thomas Gleixner , Matthew Wilcox , Arnd Bergmann , kbuild test robot , Linux ARM , corbet@lwn.net, rdunlap@infradead.org, mchehab+huawei@kernel.org Subject: Re: [PATCH v5] include: linux: Reorganize timekeeping and ktime headers Message-ID: References: <095645cd-ce53-a803-cb99-522545a409b8@vt.edu> <1c156aca-d0ad-e7e8-2238-5c3d904d171c@vt.edu> <327f5c2f-b996-8aa1-cbbf-3354e01ee1f3@vt.edu> <18f2afb6-7c42-fff1-2c79-ea473ae2b72a@vt.edu> <0ec6b0b3-0d59-ff68-13b3-c9798f3ac6c6@vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ec6b0b3-0d59-ff68-13b3-c9798f3ac6c6@vt.edu> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 01, 2021 at 10:22:21AM -0500, Carlos Bilbao wrote: > On 11/16/21 5:11 PM, Carlos Bilbao wrote: > > Reorganize and separate the headers by making ktime.h take care of the > > ktime_get() family of functions, and reserve timekeeping.h for the actual > > timekeeping. This also helps to avoid implicit function errors and strengthens > > the header dependencies, since timekeeping.h was using ktime_to_ns(), a static > > function defined in a header it does no include, ktime.h. Include the header > > timekeeping.h wherever it is necessary for a successful compilation after the > > header code reorganization. > > > > Signed-off-by: Carlos Bilbao > > Acked-by: Geert Uytterhoeven > > Reported-by: kernel test robot > > --- > > Someone, look at me! What a lonely and solitary patch I am... Yes it is, maybe the time maintainers will pick it up eventually if they feel it is valid. good luck! greg k-h