Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2623C433F5 for ; Fri, 3 Dec 2021 13:38:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381175AbhLCNlh (ORCPT ); Fri, 3 Dec 2021 08:41:37 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:58096 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381133AbhLCNlc (ORCPT ); Fri, 3 Dec 2021 08:41:32 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B45F51FD3F; Fri, 3 Dec 2021 13:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638538686; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/VcPIsmqzeeRu55wHcmrUPkfoUuFXcqt0KH2X7NHE5k=; b=xtVfH5ZNpHCJ1rTOG+z1lRdHP3oKiLAcX/i0vA28vbY0cuI5h8LDFDzZwJogkvbGcOZas6 5vbLLNxrqerqgQnyYb/RXty3hCnFjVMYIyqi8mRLtO054cQQ3D0SeATSJ/5ClHPwIXYSQY Bf5r20YkpqZsXvQX+OOqq87Y2E1exZU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638538686; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/VcPIsmqzeeRu55wHcmrUPkfoUuFXcqt0KH2X7NHE5k=; b=1phH+osAL5Pugp71279eHr7s5Ct0sHx54bNXn1J0VAo5mdB4FVrSiCgpRav5xVv4OsPY/C +pszFM38m5ZFenAw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 9F87FA3B88; Fri, 3 Dec 2021 13:38:06 +0000 (UTC) Date: Fri, 03 Dec 2021 14:38:06 +0100 Message-ID: From: Takashi Iwai To: Werner Sembach Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ALSA: hda/realtek: Fix quirk for TongFang PHxTxX1 In-Reply-To: <20211202165010.876431-1-wse@tuxedocomputers.com> References: <20211202165010.876431-1-wse@tuxedocomputers.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Dec 2021 17:50:10 +0100, Werner Sembach wrote: > > This fixes the SND_PCI_QUIRK(...) of the TongFang PHxTxX1 barebone. This > fixes the issue of sound not working after s3 suspend. > > When waking up from s3 suspend the Coef 0x10 is set to 0x0220 instead of > 0x0020. Setting the value manually makes the sound work again. This patch > does this automatically. > > While being on it, I also fixed the comment formatting of the quirk and > shortened variable and function names. > > Signed-off-by: Werner Sembach > Fixes: dd6dd6e3c791 ("ALSA: hda/realtek: Add quirk for TongFang PHxTxX1") > Cc: Thanks, applied now. Takashi