Date:   Fri, 3 Dec 2021 18:14:44 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     kbuild@lists.01.org,
        Stephane Grosjean <s.grosjean@peak-system.com>, lkp@intel.com,
        kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: drivers/net/can/usb/peak_usb/pcan_usb.c:523
 pcan_usb_decode_error() error: we previously assumed 'cf' could be null (see
 line 503)
Message-ID: <20211203151444.GK18178@kadam>
References: <202112021833.wABxM5UN-lkp@intel.com>
 <20211203145851.nrgmnu7c56w4vecy@pengutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211203145851.nrgmnu7c56w4vecy@pengutronix.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PLZIMBiuS8VtN1DH24q1TpzQ2JjjkQ8iaZuzmOl82z7d2eFPZRYv8wt7OKKH?=
 =?us-ascii?Q?rgOscxHwLc/1xTpu4NoSZB8xPYvpT3WgsFw2fsjiVfTpJZ5jVZDLSZCOh6xn?=
 =?us-ascii?Q?r1jx9H+wxoInS7WVDZGcIAFmaUXnVsSRxD1432Bw4dxLyqRZUZZJxML/qPFE?=
 =?us-ascii?Q?RV1s7Bzye0U+2sfUe+y18Le94RK6r3pOPBxWyr193lN0rAPLsjYXDoInPrVh?=
 =?us-ascii?Q?LBAysr15kxXm4oDjb5v4iK6yHB3spEfrLjmkmqHNOYI00VVSri9/uQRvP389?=
 =?us-ascii?Q?U+u13ETs4S+NSMCWByFjaecGckcfWzkG7IMCp2AzsZS8r8ZoARgsvNeFadFo?=
 =?us-ascii?Q?azOmpmACuUBlJO9JVx7sX/lGk00Mj37L340X7EmEBHJGMnzxb1wa8p0cjeA8?=
 =?us-ascii?Q?fvyjiW/iHqgLLEwcxzsypKRDPio3tpOQecALxD8rrRGf/0JSCEUaHh7U3B/P?=
 =?us-ascii?Q?uDLien2Tabkzjw0+UUQHQAroKrjV0jhXcPUCA/0Ks/gKtzevHmNpFXzk/ppe?=
 =?us-ascii?Q?Rgs5wvFswGgDF0elXU7v3ErcBw6fuzfKDlcBpbWmrmRkIe44m8S2BdzBm5YB?=
 =?us-ascii?Q?oqI85yCHkMbGWpwgnczFO7iMWAz/6u00R7WJMJeQRX3L31zlMFwyClmSrNER?=
 =?us-ascii?Q?u/CN097KR1R2YWZOc8p62CQF+ZEHtKy6v1pa+J8dQAvDl3mSemcHcB/ZUvmF?=
 =?us-ascii?Q?Lgjba9hYuUg6ZClGoQcMsjpYl93Mxfk9s4ya/O1RtLTXkNHJ4K29YbIzlGsa?=
 =?us-ascii?Q?4lHmQ5ASCUApxv7qZTt/vlYcBgMkULeVMQdXhgaZY87OzpQ34OQI47m7lh66?=
 =?us-ascii?Q?xVWvlnzzCrbmJzhguuUePMVUNE3ndMf+znmisLa0RsBBWG3JdXG0fcedAP1P?=
 =?us-ascii?Q?mJ0DHSTK/H0U3ivAnVB7KMA1QOpNVsEaaP3QzbJHnLHuVlhxP46HaWq0qXNV?=
 =?us-ascii?Q?fiNQv8V8QcsLZszRj66/EomGJLFAF8vwOBuypMH7NuLvSysTprj2TSqXHhni?=
 =?us-ascii?Q?QfLn9E821BWfHfrdS+CPxA74Htb8/7AsX8bQVbwHLLsJ3yeqQ3Y8D5Ja5U69?=
 =?us-ascii?Q?OTXkjXVpEswaoKa/0WilNJlfAdL3ufowxJEcgCFP/yeGH22+8cBO52cI/njE?=
 =?us-ascii?Q?BAPzJ4M6+iCV54uZjlMj1wNSuJ0CXhRXOVFhlLpzacqDYxOjPm5aFummxcF3?=
 =?us-ascii?Q?I9l8ODVuqHlwPMOV4k+fkkwXVvOuVLvsWCkGl+035i/Q5OyT/KwnNjjQc44G?=
 =?us-ascii?Q?XYQoS4fXCRpJp9RrMIIFPkExNVGFTn4lyiirdLI7vtbm5YDVTs1nUJEWkTbv?=
 =?us-ascii?Q?US/fPj0Jln5E9EA1CfPYOlFLUuCcmH4I4CoW3q9B14oarxS89cjppPe/1Rgr?=
 =?us-ascii?Q?ABudX7uK+AKhugzq958VnG6CC4rTjMljSSFudWB2I4I+GVMOO0/MUtjEhLur?=
 =?us-ascii?Q?HFZo63/of9AfrsL4LvQ4k+bxc3Y/LoppIndiSGtKerUvBhX/WQDzVjBusVLk?=
 =?us-ascii?Q?HFZnj7ukjX21ORCCAtRrljCSIMI28jfEQg9MjVpBeMr5YrDjS5iX6+IXpaXD?=
 =?us-ascii?Q?NXeY+O6Z+wOUwDFa3gGp1XAIw/mK4ICQi9wQ00RA/cjBjti3qd3ZfULSUZEO?=
 =?us-ascii?Q?OAMZnfmgM853Bl7U7+VDOYy4idCOvYa0CJE/KhEcCJ/aZ85TnkWomw+kB0K0?=
 =?us-ascii?Q?1+kFiGx7yOLs/D9nvboX79UAK5s=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a01302ed-2b29-4d7b-ff36-08d9b66faead
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 15:15:03.9808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IDyTR2tI+Jrb45SF+H6eSMbAh9V/3tBGdwLMCQFfAHqUP/uULOoTgCqb6gkIwtsLuXCwF22pHYNEifb24dss5S7pwJx2UznxMO+ojMZ7QNA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1486
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10186 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 adultscore=0
 bulkscore=0 malwarescore=0 mlxlogscore=967 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2112030096
X-Proofpoint-ORIG-GUID: ifRFpePmkUmM2b9FDpWoLWB7igoRz76o
X-Proofpoint-GUID: ifRFpePmkUmM2b9FDpWoLWB7igoRz76o
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 03, 2021 at 03:58:51PM +0100, Marc Kleine-Budde wrote:
> > 
> > 46be265d338833 Stephane Grosjean 2012-03-02  450  static int pcan_usb_decode_error(struct pcan_usb_msg_context *mc, u8 n,
> > 46be265d338833 Stephane Grosjean 2012-03-02  451  				 u8 status_len)
> > 46be265d338833 Stephane Grosjean 2012-03-02  452  {
> > 46be265d338833 Stephane Grosjean 2012-03-02  453  	struct sk_buff *skb;
> > 46be265d338833 Stephane Grosjean 2012-03-02  454  	struct can_frame *cf;
> > c11dcee7583027 Stephane Grosjean 2021-07-15  455  	enum can_state new_state = CAN_STATE_ERROR_ACTIVE;
> > 46be265d338833 Stephane Grosjean 2012-03-02  456  
> > 46be265d338833 Stephane Grosjean 2012-03-02  457  	/* ignore this error until 1st ts received */
> > 46be265d338833 Stephane Grosjean 2012-03-02  458  	if (n == PCAN_USB_ERROR_QOVR)
> > 46be265d338833 Stephane Grosjean 2012-03-02  459  		if (!mc->pdev->time_ref.tick_count)
> > 46be265d338833 Stephane Grosjean 2012-03-02  460  			return 0;
> > 46be265d338833 Stephane Grosjean 2012-03-02  461  
> > c11dcee7583027 Stephane Grosjean 2021-07-15  462  	/* allocate an skb to store the error frame */
> > c11dcee7583027 Stephane Grosjean 2021-07-15  463  	skb = alloc_can_err_skb(mc->netdev, &cf);
> 
> alloc_can_err_skb() ->
> alloc_canfd_skb()
> 
> https://elixir.bootlin.com/linux/v5.15/source/drivers/net/can/dev/skb.c#L210
> 
> If skb is NULL, cf is set to NULL, too.

Yeah.  Sorry about that.  The kbuild-bot doesn't do much cross function
analysis (none for functions that are not inline).  I saw that this
patch was old and could easily have checked it on my system which has
the cross function DB but I was in a rush.  :/  My bad.  Will try be a
more diligent person next time.

regards,
dan carpenter