Subject: Re: [PATCH v2 3/3] KVM: SVM: Extend host physical APIC ID field to
 support more than 8-bit
To:     Maxim Levitsky <mlevitsk@redhat.com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org
Cc:     pbonzini@redhat.com, joro@8bytes.org, seanjc@google.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        peterz@infradead.org, hpa@zytor.com, jon.grimm@amd.com
References: <20211202235825.12562-1-suravee.suthikulpanit@amd.com>
 <20211202235825.12562-4-suravee.suthikulpanit@amd.com>
 <7dd1e7d1510f17f1140b7174dd42fed752eefc38.camel@redhat.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <6cc9848a-9f04-b923-453a-6dbe03b73e58@amd.com>
Date:   Fri, 3 Dec 2021 10:34:56 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <7dd1e7d1510f17f1140b7174dd42fed752eefc38.camel@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGIrbTZrVTFCTUx5aVVzL09nTytqUWUrbVJ2NFo5KzVSRDEwS01PVmp4c3hW?=
 =?utf-8?B?NXBQNTlHYk5IamYrYytjT3lSb090ZzFFa21vOVVsY0V1dGlyZzJ1L2gyaDJm?=
 =?utf-8?B?TlQyVVVJbjJHbDhsSmhWbmw1SUNZaXZoUEFXdktuT1lsR2s2WlZIdUJvdjRz?=
 =?utf-8?B?bXIwOHg2bk9DWU1NM0NpWFF6M1VSMkYzS1VjVGdZMVVyVEpHczRNeThuWVho?=
 =?utf-8?B?S3RRa1phSXg2NFFpMTFNc3lrOHVZNHQ4VUh1cU1KMTNHbjJVQVdCRmZOWitS?=
 =?utf-8?B?djFiMFNhLy8vdTFHS3lFL3ZMeE1uTG1JQ0xLUEN6UjEyL014SmtyUjhQUGgz?=
 =?utf-8?B?Nys5MzNyTG5QVjVCTGF2L3hTU0tNN2VFWk1GcHh1RzYramVVTmtobm9BVzBJ?=
 =?utf-8?B?UExlK1JhV0VnblBnZWxLaXdhSmJ5YUlBcGkzQmZTeElCa2RYQ0xPV2g5bFVi?=
 =?utf-8?B?bDg3UDFKUDdpWUY4M05Ca3R3aGxuckhjd1cvSy9yektHMnAzQldGaDZDQnY5?=
 =?utf-8?B?K0pOYnpGbmY1V21uSG03ZjYwcUM2UElJaExvMjBxemdxSHMxUnIxc01pOFNB?=
 =?utf-8?B?OHl0anhKZ2I4YWFHRlVueGhxTWRVYXQvcitwUC8zSnBvcTFpcEZ5UExsVEFp?=
 =?utf-8?B?Rm1KR2hqR1d5dXBKbVNnKzJhT3FVSnE4RnZvZURyemtyMVExYkxERW5XVTlN?=
 =?utf-8?B?MnQzTXE0ZGN2WGRML3VuV1hWL3ZGMlQ0KzhibkVMNFM1V0JKT3J6QnJaNWd2?=
 =?utf-8?B?ak1WVktYd255VXgrL3NnOEc3SE5BYVdwM00rSTlzTGZuUjVLT1RGQ2h2Y210?=
 =?utf-8?B?Znk2SzkzTnBGbkd2YzJzN3VOWUM1dm5kbTZ5bXI4MDg5SDBUcHIvSC83NGdV?=
 =?utf-8?B?NlFmcTllMnI3RnI1YmNiOGtwSlJQMUg4YmgxLzJxSlFXRXhlcTBFVzQ4WW95?=
 =?utf-8?B?S1UwR0ZPUjQ1VGNRdTBpanZsbzFsMkNTaXJTSUlqUGNnNVA3ZW4wM1J4Rjk1?=
 =?utf-8?B?UkY2Y1RBeEx6Z3pNUFBaT0RWRFA5Wmd2SjU0b0hYWEJndUVnUW9YWDdnRGRU?=
 =?utf-8?B?WEx5WlVJQVI0cFBiNzlGY1d1SVJaQUhUaG5HNjhEdHZyNlloZFlSamtDMVJo?=
 =?utf-8?B?OVBwWUttOWVUSG5hS1Qxb2FGWU8yQlJhR2Y2N0xVNXVGbXh2UjNHRU1oVCsx?=
 =?utf-8?B?RHMvaFdmTXBzYmRaa2JVSitYaWJoVG05eXlSU1BmRTU1NEptdGtVejZXcXVK?=
 =?utf-8?B?VndNVXY5cHdNbmhDczYwcjdCbUVtODJkVjNjbGdaOVVxTVorTHlkSjF6ZURj?=
 =?utf-8?B?NmhydkcvczBTYXJsSVVFaDMwYVM4c3Vob0hHdU9vSHk3RUlYbURwVjNYWHdI?=
 =?utf-8?B?bVBPWnFncHNJeFVYakJwWE5xeTM3UEk2eHRwbnpiLzRLYWx3RzhTMVVNY3dj?=
 =?utf-8?B?RGV3OXJFNHQ0b3NsTkhaOTkwdUNjU2F0ck51dGw4SmN1bU9xM3dhajlrZnNR?=
 =?utf-8?B?SlpOTGRoZmRMTmVjOEY5Z1U5bTlrS25OZDhyM1pVRTUyWW9rUXdZV1J2V3pp?=
 =?utf-8?B?ZG83OHBPNXlYMVhlZXB1K2xpQ1hXMjlUc291RjhVM0RSdzh5KzQ1QWxWK1BI?=
 =?utf-8?B?MnJDZllOaERsa0p6Z3lPbWU1UTBoMGlEK1NvMmU2OWtteWN0aGw1K0hjMTJp?=
 =?utf-8?B?YVdQVUE4UmFXaEgzcVBtKzZ4b2o1WU1YM2FibzBZVHhoY1hqUXlQc25Sak5U?=
 =?utf-8?B?WnhDZlJlc2dIclpUZWtvNm04S2ErUmpNdXpkM2tFZ1V2eW5ZWlVCejl5czR5?=
 =?utf-8?B?cW9iZUV5bFhGUDRFMnRVaDJIVzNRZW1OT3paOTBRUmU0c1VOSEhsOXZFRzNZ?=
 =?utf-8?B?dWdYNllTWjYveVhLeG5wNk1kU2psQXBJU0wwMkdINkFlRllwMDBPeDI0ZlJy?=
 =?utf-8?B?OWlWTW01SlVVak5BL05XWVA0bnMwSFM4cmlPQnk4UVJPcXdSWnhCT1F0UDFP?=
 =?utf-8?B?UjA4bytnNTZaeG0vTVA1YXJmWGV4OXlZQ0twS0E5MFowZmhvc1pybVR3NXRY?=
 =?utf-8?B?akRrSFpnUUU0Q2wzUHdveGJXOS9MS0JEY0Z5bjZWUHJBSzBOVEV4WFdRZ25L?=
 =?utf-8?B?cGt0SUl1dXJzNFFiZmdXN3R2SEMxRnFZWFFNWE9KNFlBS05IWjlVZCszK0Ja?=
 =?utf-8?Q?FdCy6qcJd7nhxYh2f54NeTk=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 947d2ea4-6624-4dd2-c8a8-08d9b67ad8d4
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2021 16:34:59.1497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fUDIwB30ZjqJGwnY42jS2rLBxAThQyjvBdjmUyEx0BQoEeSZ/0MaIj/ax91x53by4X5bS2dQqSiZjqjtxrH1Ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5565
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/3/21 1:46 AM, Maxim Levitsky wrote:
> On Thu, 2021-12-02 at 17:58 -0600, Suravee Suthikulpanit wrote:

>> @@ -63,6 +64,7 @@
>>   static DEFINE_HASHTABLE(svm_vm_data_hash, SVM_VM_DATA_HASH_BITS);
>>   static u32 next_vm_id = 0;
>>   static bool next_vm_id_wrapped = 0;
>> +static u64 avic_host_physical_id_mask;
>>   static DEFINE_SPINLOCK(svm_vm_data_hash_lock);
>>   
>>   /*
>> @@ -133,6 +135,20 @@ void avic_vm_destroy(struct kvm *kvm)
>>   	spin_unlock_irqrestore(&svm_vm_data_hash_lock, flags);
>>   }
>>   
>> +static void avic_init_host_physical_apicid_mask(void)
>> +{
>> +	if (!x2apic_mode) {
> Wonder why this is a exported  global variable and not function.
> Not the patch fault though.
>> +		/* If host is in xAPIC mode, default to only 8-bit mask. */
>> +		avic_host_physical_id_mask = 0xffULL;
>> +	} else {
>> +		u32 count = get_count_order(apic_get_max_phys_apicid());
>> +
>> +		avic_host_physical_id_mask = BIT(count) - 1;
> I think that there were some complains about using this macro and instead encouraged
> to use 1 << x directly, but I see it used already in other places in avic.c so I don't know.

And I think it should be BIT_ULL() since avic_host_physical_id_mask is a u64.

Thanks,
Tom

>