Message-ID: <e39ddd6d-27f0-e70e-17a1-b5bb1134d2fc@kernel.org>
Date:   Fri, 3 Dec 2021 18:41:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH V8 06/14] rtla: Add timerlat tool and timelart top mode
Content-Language: en-US
To:     Tao Zhou <tao.zhou@linux.dev>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Tom Zanussi <zanussi@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-rt-users@vger.kernel.org, linux-trace-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1638182284.git.bristot@kernel.org>
 <e65a6899bbde6ecb129cfaf55e402d785ad124eb.1638182284.git.bristot@kernel.org>
 <YanfyfUgMW6KWpxS@geo.homenetwork>
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <YanfyfUgMW6KWpxS@geo.homenetwork>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/3/21 10:13, Tao Zhou wrote:
>> +/*
>> + * timerlat_top_usage - prints timerlat top usage message
>> + */
>> +static void timerlat_top_usage(char *usage)
>> +{
>> +	int i;
>> +
>> +	static const char *const msg[] = {
>> +		"",
>> +		"  usage: rtla timerlat [top] [-h] [-q] [-p us] [-i us] [-t us] [-s us] [-T[=file]] \\",
>> +		"	  [-c cpu-list] [-P priority]",
>> +		"",
>> +		"	  -h/--help: print this menu",
>> +		"	  -p/--period us: timerlat period in us",
>> +		"	  -i/--irq us: stop trace if the irq latency is higher than the argument in us",
>> +		"	  -T/--thread us: stop trace if the thread latency is higher than the argument in us",
>> +		"	  -s/--stack us: save the stack trace at the IRQ if a thread latency is higher than the argument in us",
>> +		"	  -c/--cpus cpus: run the tracer only on the given cpus	  -d/--duration time[m|h|d]: duration of the session in seconds",
>> +		"	  -t/--trace[=file]: save the stopped trace to [file|timerlat_trace.txt]",
>> +		"	  -n/--nano: display data in nanoseconds",
>> +		"	  -q/--quiet print only a summary at the end",
>> +		"	  -P/--priority o:prio|r:prio|f:prio|d:runtime:period : set scheduling parameters",
>> +		"		o:prio - use SCHED_OTHER with prio",
>> +		"		r:prio - use SCHED_RR with prio",
>> +		"		f:prio - use SCHED_FIFO with prio",
>> +		"		d:runtime[us|ms|s]:period[us|ms|s] - use SCHED_DEADLINE with runtime and period",
>> +		"						       in nanoseconds",
>> +		NULL,
>> +	};
> About help usage msg.
> 
> [-t us] --> [-T us]
> [-T=[file]] --> [-t[=file]]
> 
> [-d] [-D] [-n] lack in the head usage info 'usage: ...'
> 

Fixed in V9

-- Daniel