Message-ID: <aabde006-ce0e-fc68-63fb-58eb43648ef1@kernel.org>
Date:   Fri, 3 Dec 2021 18:42:04 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH V8 07/14] rtla/timerlat: Add timerlat hist mode
Content-Language: en-US
To:     Tao Zhou <tao.zhou@linux.dev>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Tom Zanussi <zanussi@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-rt-users@vger.kernel.org, linux-trace-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1638182284.git.bristot@kernel.org>
 <eb486340cc983bd8f7f69fe6f99f8d2927fcd296.1638182284.git.bristot@kernel.org>
 <YangwS/M9hO+o7TH@geo.homenetwork>
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <YangwS/M9hO+o7TH@geo.homenetwork>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/3/21 10:17, Tao Zhou wrote:
> On Mon, Nov 29, 2021 at 12:07:45PM +0100,
> Daniel Bristot de Oliveira wrote:
> 
>> +static void timerlat_hist_usage(char *usage)
>> +{
>> +	int i;
>> +
>> +	char *msg[] = {
>> +		"",
>> +		"  usage: [rtla] timerlat hist [-h] [-q] [-p us] [-i us] [-t us] [-s us] [-T[=file]] \\",
>> +		"         [-c cpu-list] [-P priority] [--no-irq] [--no-thread] [--no-header] [--no-summary] \\",
>> +		"         [--no-index] [--with-zeros]",
>> +		"",
>> +		"	  -h/--help: print this menu",
>> +		"	  -p/--period us: timerlat period in us",
>> +		"	  -i/--irq us: stop trace if the irq latency is higher than the argument in us",
>> +		"	  -T/--thread us: stop trace if the thread latency is higher than the argument in us",
>> +		"	  -s/--stack us: save the stack trace at the IRQ if a thread latency is higher than the argument in us",
>> +		"	  -c/--cpus cpus: run the tracer only on the given cpus",
>> +		"	  -d/--duration time[m|h|d]: duration of the session in seconds",
>> +		"	  -T/--trace[=file]: save the stopped trace to [file|timerlat_trace.txt]",
>> +		"	  -n/--nano: display data in nanoseconds",
>> +		"	  -b/--bucket-size N: set the histogram bucket size (default 1)",
>> +		"	  -e/--entries N: set the number of entries of the histogram (default 256)",
>> +		"	     --no-irq: ignore IRQ latencies",
>> +		"	     --no-thread: ignore thread latencies",
>> +		"	     --no-header: do not print header",
>> +		"	     --no-summary: do not print summary",
>> +		"	     --no-index: do not print index",
>> +		"	     --with-zeros: print zero only entries",
>> +		"	  -P/--priority o:prio|r:prio|f:prio|d:runtime:period : set scheduling parameters",
>> +		"		o:prio - use SCHED_OTHER with prio",
>> +		"		r:prio - use SCHED_RR with prio",
>> +		"		f:prio - use SCHED_FIFO with prio",
>> +		"		d:runtime[us|ms|s]:period[us|ms|s] - use SCHED_DEADLINE with runtime and period",
>> +		"						       in nanoseconds",
>> +		NULL,
>> +	};
> 
> [-t us] --> [-T us]
> [-T[=file]] --> [-t[=file]]
> [-d] [-b] [-e] [-n] lack in usage info. this is not important tho.
> 

Fixed in V9

-- Daniel