Subject: Re: [PATCH] media: s5p-jpeg: Constify struct v4l2_m2m_ops
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211130212700.1253521-1-rikard.falkeborn@gmail.com>
From:   Jacek Anaszewski <jacek.anaszewski@gmail.com>
Message-ID: <e2441bf7-676c-097e-7b60-37f18078b5ef@gmail.com>
Date:   Fri, 3 Dec 2021 20:22:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211130212700.1253521-1-rikard.falkeborn@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Rikard,

Thanks for the patch.

On 11/30/21 10:27 PM, Rikard Falkeborn wrote:
> The only usage of the v4l2_m2m_ops structs is to pass their address to
> v4l2_m2m_init() which takes a pointer to const struct v4l2_m2m_ops as
> argument. Make them const to allow the compiler to put them in read-only
> memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
>   drivers/media/platform/s5p-jpeg/jpeg-core.c | 6 +++---
>   drivers/media/platform/s5p-jpeg/jpeg-core.h | 2 +-
>   2 files changed, 4 insertions(+), 4 deletions(-)

Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

-- 
Best regards,
Jacek Anaszewski