MIME-Version: 1.0
References: <20211115174102.2211126-1-pgonda@google.com> <20211126051944.GA17358@gondor.apana.org.au>
In-Reply-To: <20211126051944.GA17358@gondor.apana.org.au>
From:   Peter Gonda <pgonda@google.com>
Date:   Fri, 3 Dec 2021 14:48:46 -0700
Message-ID: <CAMkAt6o_bjdoQ7zTs7ZY5QrYcd2Wd7GzMzRMq8m5ZUBQRQMtVw@mail.gmail.com>
Subject: Re: [PATCH V4 0/5] Add SEV_INIT_EX support
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Thomas.Lendacky@amd.com, Marc Orr <marcorr@google.com>,
        David Rientjes <rientjes@google.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Joerg Roedel <jroedel@suse.de>,
        John Allen <john.allen@amd.com>,
        "David S. Miller" <davem@davemloft.net>,
        Paolo Bonzini <pbonzini@redhat.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 25, 2021 at 10:20 PM Herbert Xu <herbert@gondor.apana.org.au> w=
rote:
>
> On Mon, Nov 15, 2021 at 09:40:57AM -0800, Peter Gonda wrote:
> > SEV_INIT requires users to unlock their SPI bus for the PSP's non
> > volatile (NV) storage. Users may wish to lock their SPI bus for numerou=
s
> > reasons, to support this the PSP firmware supports SEV_INIT_EX. INIT_EX
> > allows the firmware to use a region of memory for its NV storage leavin=
g
> > the kernel responsible for actually storing the data in a persistent
> > way. This series adds a new module parameter to ccp allowing users to
> > specify a path to a file for use as the PSP's NV storage. The ccp drive=
r
> > then reads the file into memory for the PSP to use and is responsible
> > for writing the file whenever the PSP modifies the memory region.
> >
> > V3
> > * Add another module parameter 'psp_init_on_probe' to allow for skippin=
g
> >   PSP init on module init.
> > * Fixes review comments from Sean.
> > * Fixes missing error checking with file reading.
> > * Removed setting 'error' to a set value in patch 1.
>
> This doesn't compile cleanly for me with C=3D1 W=3D1:
>
>   CC [M]  drivers/crypto/ccp/sev-dev.o
> In file included from ../arch/x86/include/asm/bug.h:84,
>                  from ../include/linux/bug.h:5,
>                  from ../include/linux/cpumask.h:14,
>                  from ../arch/x86/include/asm/cpumask.h:5,
>                  from ../arch/x86/include/asm/msr.h:11,
>                  from ../arch/x86/include/asm/processor.h:22,
>                  from ../arch/x86/include/asm/timex.h:5,
>                  from ../include/linux/timex.h:65,
>                  from ../include/linux/time32.h:13,
>                  from ../include/linux/time.h:60,
>                  from ../include/linux/stat.h:19,
>                  from ../include/linux/module.h:13,
>                  from ../drivers/crypto/ccp/sev-dev.c:10:
> ../drivers/crypto/ccp/sev-dev.c: In function =E2=80=98sev_read_init_ex_fi=
le=E2=80=99:
> ../include/linux/lockdep.h:286:52: error: invalid type argument of =E2=80=
=98->=E2=80=99 (have =E2=80=98struct mutex=E2=80=99)
>  #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)
>                                                     ^~
> Please fix and resubmit.

Thanks. Submitted a V5.1 with fixes.

>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt