Subject: Re: PATCH: Update disable_IO_APIC to use 8-bit destination field 
	(X86_64)
From: Benjamin Romer <benjamin.romer@unisys.com>
To: vgoyal@in.ibm.com
Cc: "Eric W. Biederman" <ebiederm@xmission.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20070119034944.GA7136@in.ibm.com>
References: <1169052407.3082.43.camel@ustr-romerbm-2.na.uis.unisys.com>
	 <m1tzyp8o8v.fsf@ebiederm.dsl.xmission.com>
	 <20070118034153.GA5406@in.ibm.com> <20070118043639.GA12459@in.ibm.com>
	 <m1tzyo7qtc.fsf@ebiederm.dsl.xmission.com>
	 <20070118080003.GC31860@in.ibm.com>
	 <1169141034.6665.6.camel@ustr-romerbm-2.na.uis.unisys.com>
	 <m14pqo6w3d.fsf@ebiederm.dsl.xmission.com>
	 <1169147619.6665.11.camel@ustr-romerbm-2.na.uis.unisys.com>
	 <20070119034944.GA7136@in.ibm.com>
Content-Type: text/plain
Organization: Unisys Corporation
Date: Fri, 19 Jan 2007 10:11:10 -0500
Message-Id: <1169219470.2819.9.camel@ustr-romerbm-2.na.uis.unisys.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1388
Lines: 42

On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote:
> On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote:
> [..]
> > > >
> > > > OK, here's the updated patch that uses the new definition and fixes up
> > > > the other places that use it. I built and tested this on the ES7000/ONE
> > > > and it works well. :)
> > >
> > > Cool.
> > >
> > > I hate to pick nits by why the double underscore on dest?
> > >
> > 
> > It was defined that way in the updated structure definition you sent in
> > a previous mail, so I figured you wanted it that way. Here's another
> > revision with the double underscores removed. :)
> > 
> > -- Ben
> > 
> 
> This patch looks good to me. You might want to provide some description
> too for changelog.
> 
> Thanks
> Vivek

A simple description would look something like:

- Updated 4-bit IO-APIC physical dest field to 8-bit dest field for
xAPIC; fixes ES7000/ONE kexec timer hang

Is there a changelog file in the kernel for kexec somewhere, or does
this belong in the source file's comments somewhere? I can fix up the
patch as soon as I know where the right spot for the description is. :)

-- Ben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/