Date:   Sat, 4 Dec 2021 10:46:17 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Jason Kridner <jkridner@beagleboard.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counter: ti-eqep: Enable for TDA4VM/J721E
Message-ID: <YarIaXSfewK/nCZs@shinobu>
References: <20211130193346.678544-1-jkridner@beagleboard.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ytbyk5ErfLA/LQ3L"
Content-Disposition: inline
In-Reply-To: <20211130193346.678544-1-jkridner@beagleboard.org>
Precedence: bulk


--ytbyk5ErfLA/LQ3L
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 30, 2021 at 02:33:46PM -0500, Jason Kridner wrote:
> Counter TI-EQEP was tested on TDA4VM/J721E SoC.
>=20
> Overlay used for testing EQEP0 and EQEP1:
>=20
>     &cbass_main {
> 	#address-cells =3D <2>;
> 	#size-cells =3D <2>;
>=20
> 	eqep0: qep@3200000 {
> 		compatible =3D "ti,am3352-eqep";
> 		reg =3D <0 0x3200000 0 0x100>;
> 		power-domains =3D <&k3_pds 94 TI_SCI_PD_EXCLUSIVE>;
> 		clocks =3D <&k3_clks 94 0>;
> 		clock-names =3D "eqep0-ficlk";
> 		interrupts =3D <GIC_SPI 322 IRQ_TYPE_EDGE_RISING>;
> 		interrupt-names =3D "eqep0";
> 		symlink =3D "bone/eQEP0"; /* A - P9_42, B - P9_27 */
>=20
> 		count_mode =3D <0>;
> 		swap_input =3D <0>;
> 		invert_qa =3D <1>;
> 		invert_qb =3D <1>;
> 		invert_qi =3D <0>;
> 		invert_qs =3D <0>;
> 	};
>=20
> 	eqep1: qep@3210000 {
> 		compatible =3D "ti,am3352-eqep";
> 		reg =3D <0 0x3210000 0 0x100>;
> 		power-domains =3D <&k3_pds 95 TI_SCI_PD_EXCLUSIVE>;
> 		clocks =3D <&k3_clks 95 0>;
> 		clock-names =3D "eqep1-ficlk";
> 		interrupts =3D <GIC_SPI 323 IRQ_TYPE_EDGE_RISING>;
> 		interrupt-names =3D "eqep1";
> 		symlink =3D "bone/eQEP1"; /* A - P8_35, B - P8_33 */
>=20
> 		count_mode =3D <0>;
> 		swap_input =3D <0>;
> 		invert_qa =3D <1>;
> 		invert_qb =3D <1>;
> 		invert_qi =3D <0>;
> 		invert_qs =3D <0>;
> 	};
>=20
> 	eqep2: qep@3220000 {
> 		status =3D "disabled";
> 		compatible =3D "ti,am3352-eqep";
> 		reg =3D <0 0x3220000 0 0x100>;
> 		power-domains =3D <&k3_pds 96 TI_SCI_PD_EXCLUSIVE>;
> 		clocks =3D <&k3_clks 96 0>;
> 		clock-names =3D "eqep2-ficlk";
> 		interrupts =3D <GIC_SPI 324 IRQ_TYPE_EDGE_RISING>;
> 		interrupt-names =3D "eqep2";
>=20
> 		count_mode =3D <0>;
> 		swap_input =3D <0>;
> 		invert_qa =3D <1>;
> 		invert_qb =3D <1>;
> 		invert_qi =3D <0>;
> 		invert_qs =3D <0>;
> 	};
>     };
>=20
> Signed-off-by: Jason Kridner <jkridner@beagleboard.org>

Hello Jason,

The change in this patch is a simple architecture enablement so I don't
have a problem with it given that it's been tested. However, I would
like the commit message simplified as Nishanth recommends before we
merge this patch, so please resubmit it to clean that up. Regardless,
for the code change itself I'll give my ack.

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> ---
>  drivers/counter/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 2de53ab0dd25..453490059c88 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -51,7 +51,7 @@ config STM32_LPTIMER_CNT
> =20
>  config TI_EQEP
>  	tristate "TI eQEP counter driver"
> -	depends on (SOC_AM33XX || COMPILE_TEST)
> +	depends on (SOC_AM33XX || ARCH_K3 || COMPILE_TEST)
>  	select REGMAP_MMIO
>  	help
>  	  Select this option to enable the Texas Instruments Enhanced Quadrature
> --=20
> 2.30.2
>=20

--ytbyk5ErfLA/LQ3L
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmGqyEkACgkQhvpINdm7
VJIk8w/+M2rvWvbZoEfqexSfGV9Et/Td040UGwdDojE6tsRnftjhQESZqgSl45DS
2OHUMWm26NWfKJeSjlTiaMa8/FhxkkszASZiAg0KAI0bT25RHTAHacUKbNcd3T54
IWF/mk0sL+M75o/NF/EUT3d0pqgEFir8qWLlQ39o5p4gLhcahwUAk3a6lgF0AfiY
tFbK8TzUhkaWqtVj5HajUhhuP8IiZvyRGfoREl4Es0awhMS0MdVQpWL2uLvHCJWn
X5zMhWUoVs7s33y4UT1dG0dPVmbvY6XhuTh2a4QPyLrlVevqi2nzcW0gQPxjRoHi
f03tjqrIz/46m61bk43eDASxEGJDGIU2MNcC6v4ay+pDkj7zpsHH8R55H2/kNV58
vHARh9EQDfO1UVyTE+KicEec1NO/aZmAOhgGim0ChHRyPQgxojYtwAIrB0d8Ny/w
h03rHp451q757LcZpX89bdbsl0wVxWISs7SRMimVSvwCF2ClusFrEwzlh4RFZYch
qUD6Gbu71jYzNpk4g2vUxBL+OxLFjR2L95Lhdd4BZ62q3u725t+HELv7v4jD6aWX
dzgIIii6c2mBGklmwrTSkkR2WZDNfyn10bYN8QUcSyFnJ/PD1ZCwxAKrryXtCl10
NxRn149WFcS6Rxv2pBuPyVUUl82WzGMHlDlv8DcmwuBj/XME9VY=
=oFUa
-----END PGP SIGNATURE-----

--ytbyk5ErfLA/LQ3L--