Message-ID: <06f74e760966a090027bcfec8c22e97bc040e933.camel@perches.com>
Subject: Re: [PATCH] xen-blkfront: Use the bitmap API when applicable
From:   Joe Perches <joe@perches.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>, sstabellini@kernel.org,
        roger.pau@citrix.com, axboe@kernel.dk
Cc:     xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Date:   Fri, 03 Dec 2021 23:05:37 -0800
In-Reply-To: <f9a5bc6c-347b-8243-2784-04199ef879c2@wanadoo.fr>
References: <1c73cf8eaff02ea19439ec676c063e592d273cfe.1638392965.git.christophe.jaillet@wanadoo.fr>
         <c529a221-f444-ad26-11ff-f693401c9429@suse.com>
         <d8f87c17-75d1-2e6b-65e1-23adc75bb515@wanadoo.fr>
         <6fcddba84070c021eb92aa9a5ff15fb2a47e9acb.camel@perches.com>
         <3d71577f-dabe-6e1a-4b03-2a44f304b702@wanadoo.fr>
         <863f2cddacac590d581cda09d548ee0a652df8a1.camel@perches.com>
         <1e9291c6-48bb-88e5-37dc-f604cfa4c4db@wanadoo.fr>
         <a6dd44e2-6ea6-d085-0131-1e9bac49461a@oracle.com>
         <f9a5bc6c-347b-8243-2784-04199ef879c2@wanadoo.fr>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.4-1ubuntu2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 2021-12-04 at 07:57 +0100, Christophe JAILLET wrote:
> So, maybe adding an "official" 'bitmap_size()' (which is already 
> existing and duplicated in a few places) would ease things.
> 
> It would replace the 'nr_minors = BITS_TO_LONGS(end) * BITS_PER_LONG;' 
> and hide the implementation details of the bitmap API.
> 
> Something like:
> static __always_inline size_t bitmap_size(unsigned long nr_bits)
> {
> 	return BITS_TO_LONGS(nr_bits) * sizeof(long);
> }

Or maybe a bitmap_realloc