Subject: Re: [PATCH V1] firmware: tegra: fix error application of sizeof to
 pointer
To:     Thierry Reding <thierry.reding@gmail.com>, cgel.zte@gmail.com
Cc:     arnd@arndb.de, lv.ruyi@zte.com.cn, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, Zeal Robot <zealci@zte.com.cn>
References: <20211009085900.509697-1-lv.ruyi@zte.com.cn>
 <YW1/X73f99H6g5sY@orome.fritz.box>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <bc1b1099-3365-db6a-5864-0365235f28c3@nvidia.com>
Date:   Sat, 4 Dec 2021 08:01:35 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YW1/X73f99H6g5sY@orome.fritz.box>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?gkrlsEp7lk8avoEfLwWX5JQsHWwLBCjf+klDj+9vwLXQnapp5Rkxkq3Z?=
 =?Windows-1252?Q?FAFsm+UsuGUxnML8Bhsx5c/1qVdNTCPWFGZoj3EQ8sM/6wiIX7iavTak?=
 =?Windows-1252?Q?6RbN0ecFfxlqwtaPNg/tsrWEUS7WtdQR9MlfqD0wv/y9INWiVS5Gi89f?=
 =?Windows-1252?Q?KbgbDJrmutQSkdOSIuqX8SIUHqZCV/CQ0IupAhtH9uCcQ7Ltq6fVW/vo?=
 =?Windows-1252?Q?BmVVxpdxfXpn/bTB+ripJZ3qk7ZvfSsNFgSVKSCGanUy8ZUSzkiI/Ecw?=
 =?Windows-1252?Q?yofOQWL3CL07URSBB+MQGlAECDKg5ijjGExatPNXnfsIyA++tx+g9me2?=
 =?Windows-1252?Q?0Kv/Wz7z/BwHrISeeqjWV30ghkHYBHAXz6viR+4BdK3SFa3A7TehybCT?=
 =?Windows-1252?Q?4OCoYlkMbU9OQQ6QHl8xJzDrUAARS/f/Gcaqb5CEqGNnBLOi2ibyrq21?=
 =?Windows-1252?Q?bCoY3HiXfZBh71kg15pVRgGBJ7EEbGiQ1YuvnF3i2Um2iuU9Gh+8OU9j?=
 =?Windows-1252?Q?zeJ3IglTiAMdFiu4QScsKaj26AzG+aUCc0CFh1IYAtJpVStTuBcGnf26?=
 =?Windows-1252?Q?do2L6Q57iOTDdKqrm5/Wzt+8t5IhUWB63j5d7o2MrGU/OV4zQfhHQxo0?=
 =?Windows-1252?Q?Aa0SSByg5Spj42oB00RQov1LkvNPyJDdTlHWiOwZKjpk+2tO0Pw5UuOA?=
 =?Windows-1252?Q?WwfwktE74zb1Hc69DHw7XTbZgiIaVBrbzCyXgsg6Er21iwrTt5wB3c8x?=
 =?Windows-1252?Q?h5bljh7IAUHbGA26EefDLJwctXHsZqnVSN5rUnk+dioO0UhI7/xoENL6?=
 =?Windows-1252?Q?8cM02QbNxkWHMZJpVPtnXMKyTuiu3J1Yw+xTnX7TKl+DYPdurjaBZ7r5?=
 =?Windows-1252?Q?lhGGmQfqxJAf6dJqEyaTYPj7tNNbKkMHfDuQ2MPDOaEHJ4gAEbsBya/f?=
 =?Windows-1252?Q?brhqP8aACsHJPZLWPiULiEOD0AlCgotLNHJv+b0S/FbvuGWnwerngXgw?=
 =?Windows-1252?Q?EtK5YcCzNbpcYcSTBdkCj9xq2OcrQNLSLyvZQiYZsCc8WZhmCRyN+Q2i?=
 =?Windows-1252?Q?J14ZkHpMve/VUEvGsiMVzQMQQwifj/nS+QT9j3l9G6xYarUXae0/sHKp?=
 =?Windows-1252?Q?0xjru1hXJsflyz9EKrtHWlNkTaO5puLDXT4IY/s3lKjyX4o6mfLIUblf?=
 =?Windows-1252?Q?sjfE03fC6tq/LhsivWUakGla6/SJKkigsiuZWcUPivzK7L9TGTjXgTl/?=
 =?Windows-1252?Q?rt9NXIYDh/Hn1IU967WzQPhXCcwuAlxl9G1nl6TqDv5aX8pL01isKWqG?=
 =?Windows-1252?Q?7uR5WtD3XC/4RVxcF0KxnfVvEGTMHuPJRn+gurJsY2aHYmiksBkWINPr?=
 =?Windows-1252?Q?/mT7ieacH75VYSY7TQjj6qiu4uNSDsJTJhLuVtbg1SAC9EaOe++KN+7a?=
 =?Windows-1252?Q?3JXosA/TNALfyANeQU0Ho4Va5ldsiJFWIiY6gczk+jr41zV4MsqcCJo7?=
 =?Windows-1252?Q?hmZYePR8+tEt4n+9tORpn1bXQ7tyZPeogkEZ0rqPIoul/bN1BQA8EUgR?=
 =?Windows-1252?Q?xviKcOxZvuFLnWxLTEV88EYZoS9OTDX/wPpF0UhR/U6bTHCqlIFEYvdi?=
 =?Windows-1252?Q?ihVVVco/WEx6HtY0ba0+Zr3ibfVyanRRz9jorq8X/DCtr5pwl5QRSqWj?=
 =?Windows-1252?Q?GRl1hf1mK2KNU5nTfcabIOMuQH79vKsD8KAfv7uR84LP0krXY2uBtTRs?=
 =?Windows-1252?Q?tI5MlS24OHD3yhT1nu15QAFgcoFbtPMnMgzsd+meerg3xG4xOMkneRVW?=
 =?Windows-1252?Q?B/6U1NAsGCuNzt5RB61TNy0FOg0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bea2f6c5-014f-4da9-16c3-08d9b6fc4fa5
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2021 08:01:43.5671
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DAEcNtUrS4ZJpCpKAiVQBwR8xGbggA21jG25Dgbnfb7j8ORdxSC4uh9YNy1qNFchKzSx3hX2QbtI5g65P0GQXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5460
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thierry,

On 18/10/2021 15:06, Thierry Reding wrote:
> On Sat, Oct 09, 2021 at 08:59:00AM +0000, cgel.zte@gmail.com wrote:
>> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>>
>> Application of sizeof to pointer yields the number of bytes of the pointer,
>> but it should use the length of buffer in the code.
>>
>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
>> ---
>>   drivers/firmware/tegra/bpmp-debugfs.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Applied, thanks.


We need to apply this as a fix for v5.16. I am still seeing a failure 
for reading the BPMP debugfs on v5.16-rc3.

Jon

-- 
nvpublic