Date:   Sat, 4 Dec 2021 11:28:54 +0100
From:   Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To:     Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc:     andrew@lunn.ch, gregory.clement@bootlin.com,
        sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm/arm64: dts: Add MV88E6393X to CN9130-CRB
 device tree
Message-ID: <20211204112854.2f4aa818@thinkpad>
In-Reply-To: <20211018011211.3836590-3-chris.packham@alliedtelesis.co.nz>
References: <20211018011211.3836590-1-chris.packham@alliedtelesis.co.nz>
        <20211018011211.3836590-3-chris.packham@alliedtelesis.co.nz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Chris,

some nitpicks here,

> +
> +	sfp: sfp {
> +		compatible = "sff,sfp";
> +		i2c-bus = <&cp0_i2c1>;
> +		mod-def0-gpios = <&expander0 3 GPIO_ACTIVE_LOW>;
> +		los-gpio = <&expander0 15 GPIO_ACTIVE_HIGH>;
> +		tx-disable-gpio = <&expander0 2 GPIO_ACTIVE_HIGH>;
> +		tx-fault-gpio = <&cp0_gpio1 24 GPIO_ACTIVE_HIGH>;

maximum-power-milliwatt = <3000>; AFAIK

...

> +			port@9 {
> +				reg = <9>;
> +				label = "p9";
> +				phy-mode = "10gbase-r";
> +				sfp = <&sfp>;
> +				managed = "in-band-status";
> +			};
> +
> +			port@10 {

port@a (hexadecimal in node name)

> +				reg = <10>;
> +				label = "cpu";
> +				ethernet = <&cp0_eth0>;

Marek