Date:   Sat, 4 Dec 2021 11:46:00 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     zhenwei pi <pizhenwei@bytedance.com>
Cc:     tglx@linutronix.de, pbonzini@redhat.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: Re: [PATCH v2 1/2] x86/cpu: Introduce x86_get_cpufreq_khz()
Message-ID: <20211204104600.GT16608@worktop.programming.kicks-ass.net>
References: <20211201024650.88254-1-pizhenwei@bytedance.com>
 <20211201024650.88254-2-pizhenwei@bytedance.com>
 <20211202222514.GD16608@worktop.programming.kicks-ass.net>
 <947de021-df91-9219-7378-8addc6f66612@bytedance.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <947de021-df91-9219-7378-8addc6f66612@bytedance.com>
Precedence: bulk

On Fri, Dec 03, 2021 at 03:34:04PM +0800, zhenwei pi wrote:
> A KVM guest overwrites the '.calibrate_tsc' and '.calibrate_cpu' if kvmclock
> is supported:
> 
> in function kvmclock_init(void) (linux/arch/x86/kernel/kvmclock.c)
> 	...
>         x86_platform.calibrate_tsc = kvm_get_tsc_khz;
>         x86_platform.calibrate_cpu = kvm_get_tsc_khz;
> 	...
> 
> And kvm_get_tsc_khz reads PV data from host side. Before guest reads this,
> KVM should writes the frequency into the PV data structure.
> 
> And the problem is that KVM gets tsc_khz directly without aperf/mperf
> detection. So user may gets different frequency(cat /proc/cpuinfo) from
> guest & host.
> 
> Or is that possible to export function 'aperfmperf_get_khz'?

TSC frequency and aperf/mperf are unrelated. You're trying to make apple
juice with carrots.