MIME-Version: 1.0
References: <1638542272-15187-1-git-send-email-wang.yong12@zte.com.cn> <20211203130210.f34079f175f28bd1c5c26541@linux-foundation.org>
In-Reply-To: <20211203130210.f34079f175f28bd1c5c26541@linux-foundation.org>
From:   yong w <yongw.pur@gmail.com>
Date:   Sat, 4 Dec 2021 19:23:20 +0800
Message-ID: <CAOH5QeDZH4vsjN_hHXfe48XYA02ekf4XvynOQ=GzbtgD9cVzgw@mail.gmail.com>
Subject: Re: [PATCH linux-next] delayacct: track delays from memory compact
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     bsingharora@gmail.com,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>, mingo@kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>, yang.yang29@zte.com.cn,
        wang.yong12@zte.com.cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Sorry, the patch has something wrong.
I'll resend the patch later.

Thanks!

Andrew Morton <akpm@linux-foundation.org> =E4=BA=8E2021=E5=B9=B412=E6=9C=88=
4=E6=97=A5=E5=91=A8=E5=85=AD 05:02=E5=86=99=E9=81=93=EF=BC=9A
>
> On Fri,  3 Dec 2021 06:37:52 -0800 yongw.pur@gmail.com wrote:
>
> > From: wangyong <wang.yong12@zte.com.cn>
> >
> > Delay accounting does not track the delay of memory compact.
> > When there is not enough free memory, tasks can spend
> > a amount of their time waiting for memory compact.
> >
> > To get the impact of tasks in direct memory compact, measure
> > the delay when allocating memory through memory compact.
> >
> > ...
> >
> > --- a/include/linux/delayacct.h
> > +++ b/include/linux/delayacct.h
> > @@ -42,8 +42,13 @@ struct task_delay_info {
> >       u64 thrashing_start;
> >       u64 thrashing_delay;    /* wait for thrashing page */
> >
> > +     u64 compact_start;
> > +     u64 compact_delay;      /* wait for memory compact */
> > +
> > +     u64 freepages_start;
>
> task_delay_info already has a freepages_start, so it fails to compile.
>
> Did you send the correct version?
>