From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 net-next 4/5] net: mscc: ocelot: split register
 definitions to a separate file
Thread-Topic: [PATCH v2 net-next 4/5] net: mscc: ocelot: split register
 definitions to a separate file
Thread-Index: AQHX6KpvFCgGsEi6gkyWUdzaZYVwl6wiO7iA
Date:   Sat, 4 Dec 2021 12:00:28 +0000
Message-ID: <20211204120027.vov363wzmk6yngbz@skbuf>
References: <20211204010050.1013718-1-colin.foster@in-advantage.com>
 <20211204010050.1013718-5-colin.foster@in-advantage.com>
In-Reply-To: <20211204010050.1013718-5-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EdUWh+TQNSVtVXzFQzUHXTwf8xgV88rLOBm+57cVNs14wvP1KnuCcOCKeTtM?=
 =?us-ascii?Q?tphzTA+sKmqgo6aCevOHmQtfuIgCXeVI8AVvpDkuoYEv5RgzaWTTdEdR2YdX?=
 =?us-ascii?Q?zuzf9qChY0b4hPUrNMdCUJLvmZzR5J91QRVzlpmRWlazvFXLTv1g5ZvOP6Kr?=
 =?us-ascii?Q?oKjRvWCNNmN3+5QbGiGRxIbWnds2A0LZcgi67aAPDy43ZYnR9LssTfjUmzMC?=
 =?us-ascii?Q?uvoDa37Ua347C5b7SMuDfsS43UljACymMfvXWVJxVDxffVa5jhMcvZ50zaLt?=
 =?us-ascii?Q?QWJ8tS+BbllPXmp+k69xxzHTSLcZH4OWUhb0EodOshC1sfEpw0aZucKgnNMf?=
 =?us-ascii?Q?mBd3JYZfVfL3WjCnoTaJzaq99Ei4FLU603mVfgew6ApwrzkGW+iseq9ajU5k?=
 =?us-ascii?Q?XqcGIHuX0xbQIGBPFNITlu3asgSvjSS5Vn/MPZCVIcuAly8VdTb8sMIOo7lR?=
 =?us-ascii?Q?vw3SoqW3mym+JJTzXI2w0CfQv6s4bzoygEG9gl3ftjqMNq08UyUAJsdG5JYP?=
 =?us-ascii?Q?Aglssw39QSr6W4mfAKthTKrcZUxDVE+o2DwUI8x0M2XzHcvI4O8uE1GIm0Y9?=
 =?us-ascii?Q?m5PknEnkQD4LRxxWP1if9uSDzsZkbDIBFffa7WsBNHUxU59jI9fs1/LsmJ/w?=
 =?us-ascii?Q?e+nwuc8+awr103p1rVxSnole46QmZCnDfNqIgcNURYEPBuK2G8Jiol+o3R7Q?=
 =?us-ascii?Q?lfV8QZLLhZTnRpZFIHs0zQUrpSaB04yxfxCK1Ia7ONoYMpdvrKJdMdw3qpIU?=
 =?us-ascii?Q?Alo7PUkMwsG21HLZMnSzNZvoMz/dnDesFP+XL7nzLQx3sWE5XBjezOyfaIJj?=
 =?us-ascii?Q?RZnVW/RoARJj0npciv4giTOhx/gpFHNA7fCYaJXxgo8lxif58y8SKzUIetIN?=
 =?us-ascii?Q?EuNlTsrFvAzl/crnRPGeu0zkpvUfAb7JOvXJxaSlhMS10ELz90v6gpZcybXl?=
 =?us-ascii?Q?vsSfIj+UG7qOQBE6Nv/0+fT4hw8CiqWOblApKbTdwDaKRfULoYT1U+zmdMay?=
 =?us-ascii?Q?5wxDAzwTLsGAP7mN1tg5K81ju0Hmq0KBnXs9UdkBm7pnIVR3BcV030yTLbCJ?=
 =?us-ascii?Q?xaMOq0bBNQtrjp8TeGPi8vqs+lIw/sVyrCbVOTN/s2NWbuPlHuI0ZWfzJizO?=
 =?us-ascii?Q?VHFDFQ4IL7BvpOIGxv2fxhdmB4XxZS50ZlHZDVXt8Vxc/+D0HpMxiNu9izKq?=
 =?us-ascii?Q?ucHaQArichXioCOQiED3mf6q7LvNcOh//8WooU5mjXIURTiyTsL5zXDU9eGe?=
 =?us-ascii?Q?14s1HGbuWYo2g/FD8mdC1oTI7CtDbPxQmWnCb26SfrRl32j6G9KmizkEncN9?=
 =?us-ascii?Q?IzNfHAcf4yGGc45WscrbBdsYOkUFUit8g8/lD8aHCQ6Iv8hGsV3B3PZalkV4?=
 =?us-ascii?Q?ki6cfkil4lCQZfFAZISGzGB9j2SUZhaPLBTQWGMLhYgV+HhEc4Bax/e0pDHr?=
 =?us-ascii?Q?iwxUubfK37o2JOHPRTAmC31fYG5mBOqLcIF/EeHI9SvQZHQ+g7+ZU9CmAI24?=
 =?us-ascii?Q?P/tE1BEKygu8h3Zd+vYukcrzW8ZpwvHEaqQmt4sOFzc14jo7ivwc24PXOGBz?=
 =?us-ascii?Q?x/g6vIRl/9bpGymQIZQpm2r3U3t+DdCmI3e3WpO0Vm3+9PjVKRiRql23oU4M?=
 =?us-ascii?Q?enNDHlj4GWxV3PgnMmKB1ks=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <74FE4A84F4835D43B2B42D31421CB254@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 094c2b97-13e6-4e30-33a3-08d9b71daa0a
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2021 12:00:28.2959
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 271xGjGel0BRUtA0BZLvwM5LYSsTN83bVs1WtaozGHf48H/0OXhFt8u61z5KKPqimvx6uRwjjg7bfH2K5bvIkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2800
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 03, 2021 at 05:00:49PM -0800, Colin Foster wrote:
> Move these to a separate file will allow them to be shared to other
> drivers.
>=20
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Reported-by: kernel test robot <lkp@intel.com>

I wouldn't keep the "Reported-by" tag in this case.

> ---
>  drivers/net/ethernet/mscc/Makefile         |   3 +-
>  drivers/net/ethernet/mscc/ocelot_vsc7514.c | 520 +-------------------
>  drivers/net/ethernet/mscc/vsc7514_regs.c   | 522 +++++++++++++++++++++
>  include/soc/mscc/vsc7514_regs.h            |  27 ++
>  4 files changed, 562 insertions(+), 510 deletions(-)
>  create mode 100644 drivers/net/ethernet/mscc/vsc7514_regs.c
>  create mode 100644 include/soc/mscc/vsc7514_regs.h
>=20
> diff --git a/drivers/net/ethernet/mscc/vsc7514_regs.c b/drivers/net/ether=
net/mscc/vsc7514_regs.c
> new file mode 100644
> index 000000000000..b041756d1b78
> --- /dev/null
> +++ b/drivers/net/ethernet/mscc/vsc7514_regs.c
> @@ -0,0 +1,522 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Microsemi Ocelot Switch driver
> + *
> + * Copyright (c) 2017 Microsemi Corporation
> + * Copyright (c) 2021 Innovative Advantage
> + */
> +#include <soc/mscc/ocelot_vcap.h>

With Jakub's comment to add an include here (which is to resolve these
warnings):
https://patchwork.hopto.org/static/nipa/590203/12656181/build_32bit/stderr
it looks fine, so please change this and then add my:

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>=