MIME-Version: 1.0
References: <20211204174033.950528-1-arnd@kernel.org>
In-Reply-To: <20211204174033.950528-1-arnd@kernel.org>
From:   Sergey Ryazanov <ryazanov.s.a@gmail.com>
Date:   Sat, 4 Dec 2021 21:15:41 +0300
Message-ID: <CAHNKnsScMsxMnk5XLM+yBWftAvfhjXb_qmLgwMbVqBVqO77gSQ@mail.gmail.com>
Subject: Re: [PATCH] net: wwan: iosm: select CONFIG_RELAY
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Loic Poulain <loic.poulain@linaro.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        M Chetan Kumar <m.chetan.kumar@linux.intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Johannes Berg <johannes@sipsolutions.net>,
        Stephan Gerhold <stephan@gerhold.net>, netdev@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Dec 4, 2021 at 8:40 PM Arnd Bergmann <arnd@kernel.org> wrote:
> The iosm driver started using relayfs, but is missing the Kconfig
> logic to ensure it's built into the kernel:
>
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_create_buf_file_handler':
> iosm_ipc_trace.c:(.text+0x16): undefined reference to `relay_file_operations'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_subbuf_start_handler':
> iosm_ipc_trace.c:(.text+0x31): undefined reference to `relay_buf_full'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_ctrl_file_write':
> iosm_ipc_trace.c:(.text+0xd5): undefined reference to `relay_flush'
> x86_64-linux-ld: drivers/net/wwan/iosm/iosm_ipc_trace.o: in function `ipc_trace_port_rx':
>
> Fixes: 00ef32565b9b ("net: wwan: iosm: device trace collection using relayfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>