Date:   Sat, 4 Dec 2021 10:23:13 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc:     Vladimir Oltean <vladimir.oltean@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v3 net-next 0/5] prepare ocelot for external interface
 control
Message-ID: <20211204182313.GB1037231@euler>
References: <20211204182129.1044899-1-colin.foster@in-advantage.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211204182129.1044899-1-colin.foster@in-advantage.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MvKfHy1J4xwimDljnvY5Too+CjNQB5sC4xzMtrGTLlcaDRcEwyDzju8l2MQA?=
 =?us-ascii?Q?EUEjlyY2Tjvw8nG/ghbUfexiVrU0D4wcILqLiiCc4QE7ap4LmtRPk2A/CLKA?=
 =?us-ascii?Q?HkkxOVdBOPlvyk++WGOvGnvah7G66jMXKL/vIL3TMZdB4tdJ2bqqeKmU9Jwd?=
 =?us-ascii?Q?2DMuWaupqh98jZ3ev0G/BmS0hK2qw0+8HxnYBWcadJospkNXp3j/vEJtM/z7?=
 =?us-ascii?Q?5lbDA39SfMNUbzWoJGRzNSQhyEKlKsBfYzOMJN6boQDx/ldK7JMgXynQPAnB?=
 =?us-ascii?Q?nR+31nEvsjcsVHl30L51572537xNU2Sca8o0Jvw1MFt/sbSA7GRRsJP63or7?=
 =?us-ascii?Q?5ru+2badAhopi8UF2xjGET/vw2oWPWv4RnIL4dTHhuRrSB+bZH5Qw3yZTea/?=
 =?us-ascii?Q?ln/jWADgEUllNr1JORGq6rE1q1inY8YsNFZdkg9nczM/VLurjxjOBHinimwL?=
 =?us-ascii?Q?4nnseQnx/GtAT1BXI/tnjnUkxxKMjOpHSyRDez7cQacPPFNFJAGxBglxMjBi?=
 =?us-ascii?Q?s3hK37LYoync7IGK4dzHk4MLbZvvCGYxlfF8E7aH1UxtclwLGV9s6FVVJeuz?=
 =?us-ascii?Q?c4TyVOYk61ZZTYxGQdE3hl2+iBiI0DCXpYdbk6iGRuckuwxL1rKDdwu45yWO?=
 =?us-ascii?Q?IM9s8HBMHudQicrHeLW0xhW00dYq2tJMdTVJys607kokrLJzp/b/Vb9celHk?=
 =?us-ascii?Q?BUmDqUfJopQM5paht9yDIvGA4V+CVNQyk3vXsyPIchBikWo1SmjbcO01AEE4?=
 =?us-ascii?Q?6wbrdaqaeREINrr0dq/3I2xa7qNOnyJ/tPt7EdQ74q4TCVAX04h957TZDyNX?=
 =?us-ascii?Q?u3ym9JFl/jWrzqak5m5bNtNEJKXuhihPg2nu0HyWDLxmflGoEFyzK4skeg2Z?=
 =?us-ascii?Q?8LPAvaWRv0DykKUh7oTrearuNJgYqEyWNoePvB6bdjNchS5HS0JhTYjMOmBK?=
 =?us-ascii?Q?77ISX60gUd20OH3KszLnBSp7Scjsly5uu0T5TX0FbnOdqPrxVm+a78GXhY0Z?=
 =?us-ascii?Q?BfUI3CVoS7Tz2jwziXPsdZjQy4JtgJGljQHcZjMJ+Z5f4nQEmkuECPxAOyYV?=
 =?us-ascii?Q?C5+Qc3+sOpPzQGpiyqz9Z/WR7Xk+8kWFSzSDCm2dXJC7RDRM6bVQ3Z8VQAY7?=
 =?us-ascii?Q?y69A5uQkbFAWxMjPV7JjCEHqob8z3y0bqCOv67Qt6gz+fMtg2UwY4wfUP4d9?=
 =?us-ascii?Q?SWqAMYlFi/fzuWyEtKMjv8/nuyxY8qJrL2g7ORMPvmO+6l6dob3BwNFslo9v?=
 =?us-ascii?Q?3Ly0JvdciBORIFshNEkf6Cs1jYf/mrQHnw0wfYVC/1ZCk3O8YRptaNwU08d1?=
 =?us-ascii?Q?EKnTWzU3CHKGTB67m7FVmBlWqI8Nf4qs8g0JfG8fzzBc1crgGMAdaDx5ry82?=
 =?us-ascii?Q?Ku9a7MiLmSHYOmW9o7RV9fy+SUJsBz+3HAWD/Rc40qae9Xz2rYeMEKe+fhtz?=
 =?us-ascii?Q?s57A6YESs9ylSP+HsteIBirCcJt6XxhDrn/OpfBj6W7YY5iwlFr1qTs+BSJN?=
 =?us-ascii?Q?AuLPH8eIfqhJ3t3PbhxVvPYt788z9HXHGOSSAwGyjslQdIGjZtY4p04nHSen?=
 =?us-ascii?Q?06EjeiL87lVQqqCkQPwC+eLv8Ba7FtmMETBp8+ISZSMA0KeKGwOgIMRX6L+z?=
 =?us-ascii?Q?gYS5tesVrUb7qIlplsZukONzbCAD/Th0SpRso5dtwsUciv+xt5Iio9rDlJM2?=
 =?us-ascii?Q?guWKD/ksn1t9657x3Lbo6ge9i1w=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06708b3e-8082-4f3c-d584-08d9b753234b
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2021 18:23:15.2966
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ry8/tY0/7MA9RA/NYoh7tg3PsU9DRETJ1wMalVlZlkRBiXr3hqCl3MIPy5gwY+z17Imjvu1LaP6VaAn4xYmJto9iwsoO4JvHVOcTcqZDXsY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2061
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Dec 04, 2021 at 10:21:24AM -0800, Colin Foster wrote:
> This patch set is derived from an attempt to include external control
> for a VSC751[1234] chip via SPI. That patch set has grown large and is
> getting unwieldy for reviewers and the developers... me.
> 
> I'm breaking out the changes from that patch set. Some are trivial 
>   net: dsa: ocelot: remove unnecessary pci_bar variables
>   net: dsa: ocelot: felix: Remove requirement for PCS in felix devices
> 
> some are required for SPI
>   net: dsa: ocelot: felix: add interface for custom regmaps
> 
> and some are just to expose code to be shared
>   net: mscc: ocelot: split register definitions to a separate file
>   net: mscc: ocelot: expose ocelot wm functions
> 
> 
> The entirety of this patch set should have essentially no impact on the
> system performance.
> 
> v1 -> v2
>     * Removed the per-device-per-port quirks for Felix. Might be
>     completely unnecessary.
>     * Fixed the renaming issue for vec7514_regs. It includes the
>     Reported-by kernel test robot by way of git b4... If that isn't the
>     right thing to do in this instance, let me know :-)
> 
> v2 -> v3
>     * Fix an include. Thanks Jakub Kicinski!

Oops - I didn't use git b4 to pull in the reviewed by tags. Sending V4
with those changes and this fix. Apologies!

> 
> Colin Foster (5):
>   net: dsa: ocelot: remove unnecessary pci_bar variables
>   net: dsa: ocelot: felix: Remove requirement for PCS in felix devices
>   net: dsa: ocelot: felix: add interface for custom regmaps
>   net: mscc: ocelot: split register definitions to a separate file
>   net: mscc: ocelot: expose ocelot wm functions
> 
>  drivers/net/dsa/ocelot/felix.c             |   6 +-
>  drivers/net/dsa/ocelot/felix.h             |   4 +-
>  drivers/net/dsa/ocelot/felix_vsc9959.c     |  11 +-
>  drivers/net/dsa/ocelot/seville_vsc9953.c   |   1 +
>  drivers/net/ethernet/mscc/Makefile         |   3 +-
>  drivers/net/ethernet/mscc/ocelot_devlink.c |  31 ++
>  drivers/net/ethernet/mscc/ocelot_vsc7514.c | 548 +--------------------
>  drivers/net/ethernet/mscc/vsc7514_regs.c   | 523 ++++++++++++++++++++
>  include/soc/mscc/ocelot.h                  |   5 +
>  include/soc/mscc/vsc7514_regs.h            |  27 +
>  10 files changed, 610 insertions(+), 549 deletions(-)
>  create mode 100644 drivers/net/ethernet/mscc/vsc7514_regs.c
>  create mode 100644 include/soc/mscc/vsc7514_regs.h
> 
> -- 
> 2.25.1
>