Date: Fri, 19 Jan 2007 11:12:09 -0800
From: Randy Dunlap <rdunlap@xenotime.net>
To: Noah Watkins <nwatkins@ittc.ku.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include linux/fs.h in linux/cdev.h for struct inode
Message-Id: <20070119111209.ab02d109.rdunlap@xenotime.net>
In-Reply-To: <11692328473797-git-send-email-nwatkins@ittc.ku.edu>
References: <11692328473797-git-send-email-nwatkins@ittc.ku.edu>
Organization: YPO4
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 893
Lines: 35

On Fri, 19 Jan 2007 12:54:07 -0600 Noah Watkins wrote:

> ---
>  include/linux/cdev.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/cdev.h b/include/linux/cdev.h
> index f309b00..b53e2a0 100644
> --- a/include/linux/cdev.h
> +++ b/include/linux/cdev.h
> @@ -5,6 +5,7 @@
>  #include <linux/kobject.h>
>  #include <linux/kdev_t.h>
>  #include <linux/list.h>
> +#include <linux/fs.h>
>  
>  struct cdev {
>  	struct kobject kobj;
> -- 

You can just do this forward declaration instead:

struct inode;

since no struct members are used/needed.

This cuts down on #include spider webs & nests.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/