Date:   Sun, 5 Dec 2021 16:13:46 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Antonov <alexander.antonov@linux.intel.com>,
        Alexei Budankov <abudankov@huawei.com>,
        Riccardo Mancini <rickyman7@gmail.com>
Subject: Re: [PATCH v12 13/16] perf record: Extend --threads command line
 option
Message-ID: <YazWyEU9cUabmmYC@krava>
References: <cover.1637675515.git.alexey.v.bayduraev@linux.intel.com>
 <f103a65518a1a41700f739df75f57cb0b46fbf19.1637675515.git.alexey.v.bayduraev@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f103a65518a1a41700f739df75f57cb0b46fbf19.1637675515.git.alexey.v.bayduraev@linux.intel.com>
Precedence: bulk

On Tue, Nov 23, 2021 at 05:08:09PM +0300, Alexey Bayduraev wrote:

SNIP

> +
>  static int record__parse_threads(const struct option *opt, const char *str, int unset)
>  {
> +	int s;
>  	struct record_opts *opts = opt->value;
>  
> -	if (unset || !str || !strlen(str))
> +	if (unset || !str || !strlen(str)) {
>  		opts->threads_spec = THREAD_SPEC__CPU;
> +	} else {
> +		for (s = 1; s < THREAD_SPEC__MAX; s++) {
> +			if (s == THREAD_SPEC__USER) {
> +				opts->threads_user_spec = strdup(str);

we should bail out if strdup fails

jirka

> +				opts->threads_spec = THREAD_SPEC__USER;
> +				break;
> +			}
> +			if (!strncasecmp(str, thread_spec_tags[s], strlen(thread_spec_tags[s]))) {
> +				opts->threads_spec = s;
> +				break;
> +			}
> +		}
> +	}
> +
> +	if (opts->threads_spec == THREAD_SPEC__USER)
> +		pr_debug("threads_spec: %s\n", opts->threads_user_spec);
> +	else
> +		pr_debug("threads_spec: %s\n", thread_spec_tags[opts->threads_spec]);
>  
>  	return 0;
>  }
> @@ -3263,6 +3327,17 @@ static void record__mmap_cpu_mask_init(struct mmap_cpu_mask *mask, struct perf_c
>  		set_bit(cpus->map[c], mask->bits);
>  }
>  

SNIP