DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=ms2.inr.ac.ru;
  b=AZ6uLTDW+0kt4q9hYWYD1uEj3jgH1B5LJ75vpkF8ve7J57srDokLrUvuXa74UkI3DQAJYsjq+l7XR3wTCLS/CqhlZnvk30VLm6iO88YdhgTu31XKxSLa0YeU7kCu3m9eFjmqIakJET4Cj1Ki0nfWTcFwWrTD7ACzlVFLZK+zHgs=;
Date: Fri, 19 Jan 2007 22:16:15 +0300
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Hugh Dickins <hugh@veritas.com>
Cc: Alexey Dobriyan <adobriyan@openvz.org>, Andrew Morton <akpm@osdl.org>,
       Richard Purdie <richard@openedhand.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't map random pages if swapoff errors
Message-ID: <20070119191615.GA16601@ms2.inr.ac.ru>
References: <20070119163030.GA12507@localhost.sw.ru> <Pine.LNX.4.64.0701191754020.10013@blonde.wat.veritas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.64.0701191754020.10013@blonde.wat.veritas.com>
User-Agent: Mutt/1.5.6i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 22

Hello!

> Getting an error there is all the more reason to proceed
> with the swapoff, not to give up and break out of it.

Yes, from this viewpoint more reasonable approach would be to untie
corresponding ptes from swap entry and mark them as invalid to trigger
fault on access.

Not even tried simply because it is definitely not that thing, which
we needed. We used this for process migration and for that purpose
we really need to know when swapoff() fails ASAP to abort migration,
to kill processes which got invalid pages and to resume original copy.
Obviously, delayed fault is absolutely inappropriate for this particular
purpose.

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/