Date:   Sun, 5 Dec 2021 16:56:44 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Yinbo Zhu <zhuyinbo@loongson.cn>,
        Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v3 1/2] modpost: file2alias: make mdio alias configure
 match mdio uevent
Message-ID: <YazhPOIIzpl43tzq@lunn.ch>
References: <1638260517-13634-1-git-send-email-zhuyinbo@loongson.cn>
 <YaXrP1AyZ3AWaQzt@shell.armlinux.org.uk>
 <ea3f6904-c610-0ee6-fbab-913ba6ae36c5@loongson.cn>
 <Yas2+yq3h5/Bfvy9@shell.armlinux.org.uk>
 <YavYM2cs0RuY0JdM@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YavYM2cs0RuY0JdM@shell.armlinux.org.uk>
Precedence: bulk

> The modalias string provided in the uevent sysfs file does not conform
> to the format used in PHY driver modules. One of the reasons is that
> udev loading of PHY driver modules has not been an expected use case.
> 
> This patch changes the MODALIAS entry for only PHY devices from:
> 	MODALIAS=of:Nethernet-phyT(null)
> to:
> 	MODALIAS=mdio:00000000001000100001010100010011

Hi Russell

You patch looks good for the straight forward cases.

What happens in the case of

        ethernet-phy@0 {
            compatible = "ethernet-phy-ieee802.3-c45";


Does this get appended to the end, or does it overwrite?

     Andrew