From:   "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Coelho, Luciano" <luciano.coelho@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "Beker, Ayala" <ayala.beker@intel.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iwlwifi: mei: allow tracing to be disabled
Thread-Topic: [PATCH] iwlwifi: mei: allow tracing to be disabled
Thread-Index: AQHX6dpboJ3VcAING0q/5rZW+mljFawkM0pA
Date:   Sun, 5 Dec 2021 18:12:40 +0000
Message-ID: <SA1PR11MB58258B179D8ABB7738DCE76CF26C9@SA1PR11MB5825.namprd11.prod.outlook.com>
References: <20211205131637.3203040-1-arnd@kernel.org>
In-Reply-To: <20211205131637.3203040-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8o5UahrwUYgRpnb7JN1Ao+7/cafdDU4oNCK8d0sx8W/wFgzIRFUZtt2uVALx?=
 =?us-ascii?Q?1XBtf6fxq16nI71Xcl2k9kUIYPhdlhAj6yNvMv1iy92HXyGUKnDiHxHdGCp0?=
 =?us-ascii?Q?1j+Tza3zG8VjWT82hFStkQnGemU6L7nnJ9qSS9uQSRhRhQd5pAePTblhEDQO?=
 =?us-ascii?Q?BI7kJB1hLXxyGIlCt6qgzca8b8fH0UB/Hn2/7mUJ/RJeO1gUMlfcVC3DMPfl?=
 =?us-ascii?Q?BmawI0/P2QIaQcyMspNdZXU8FK5zz/Io8z6M/fRlyuK8HRjZz0qVeeWLpk15?=
 =?us-ascii?Q?ZmVVka0/N1RIrjiQmkrXRvRX3xgZKYOdkGAh8rm70A4GXNygTdXB5nRk6ZD6?=
 =?us-ascii?Q?XBf3SQluubL+PGdSypW8gDm2UFq6rbFxiH2LZoawT+ztIEold47w2nD1Tydo?=
 =?us-ascii?Q?lCyxVuM8XAxlkitFts+SPCawj+ebcIZv90/xROCREh+Q4RIzL7ugAKJenQqt?=
 =?us-ascii?Q?F08qAsQ3GFBCVVpFaIVk5jpeyCQvTYHMfQNdWfqP4PFORWH/rlxRwp2+7w0P?=
 =?us-ascii?Q?RpxFxFIO6eKZmsbyT+lRVkZYIfk8/3uHhqzcP2K6PnOHB1vw62ZVQ+DgWOVX?=
 =?us-ascii?Q?WPfhTEWftv0xcwv80C2AKTkNcg/sgdHyyTjgyoXeZwddEu9gBzYSszAJttZA?=
 =?us-ascii?Q?PbUElpWGFHj/JEHTLFuWYvFyGLwaWXaMFRaVROCwxxo08DA0dvpspzrARhrm?=
 =?us-ascii?Q?7iPmi5Z3uCZLol8GP7UJ8fsnaNewshovM79yxh9QWBhH6lYFmACAtXIyOiuu?=
 =?us-ascii?Q?ndrU6D8JuQRXEghqKD+5MiC7C24iAYdJxwwsDz54BYBW9alRiHcg33vmP3Co?=
 =?us-ascii?Q?vf9pi+9x7PEsJSEAPmsAgflBZGEuusipUG8faTqKE+vgHdwmG1XLXF6+dm9I?=
 =?us-ascii?Q?tJFPRj6yurUSiMn+tWsywXRiC5J88ArtEXCSe2IPtgCU+EkICrKLneg8Cr7N?=
 =?us-ascii?Q?e9txPtCSmiZBc0WSieXO2VZlP+njV9qVG7i/j/ROZDpLrZe+XmdR5WmMo5kK?=
 =?us-ascii?Q?XVMCnLQUruklu7qV7b1wODJ4WLqljCC7KOrjy1Wkct6pOyIpXzoEJh/A9NbH?=
 =?us-ascii?Q?8wBrpOpB1TfoPA1q74VN1z8MDgPFpdaeubKsa+JDE916uomDfoT7uwy7nRf6?=
 =?us-ascii?Q?ZL10RV9ZkURSJfoNoX4c66kx2Lv9mjQVcLrRtYvT449EoUnE7bdifKVs/1Wq?=
 =?us-ascii?Q?l7Y1UamlVzqG3xsdNHTcqQbWrDYwVK4P4xrVXIUAgsTfV3K1uLfIbz+kvic/?=
 =?us-ascii?Q?58vx8enJKa+jZwBoO9UCNT/jT7yfIbKsiW7DZvT9g90KIUxhD4P222aMEuKi?=
 =?us-ascii?Q?96XrgPJqxZfU/7DdZMqr9m9/37uHptKxq4J+vh+8AK/joKTXNtX4YxgdNWao?=
 =?us-ascii?Q?MmOoSHRc7sGrD15/DFcFqFh0KxGp0jVuSl0uwpjL3oY10BPcVHpoFd75ls/B?=
 =?us-ascii?Q?FM6bHLwQef3UwssK32lFo/mhokOXQ/5DKmxvfCybF/8xz/ptokmQ4+vwuuz0?=
 =?us-ascii?Q?/w1unh0FhrYvOmzOBEUY9wqutkFlkjYQ7sTlRG1VmnfIduPxTM85RhGhYJ+m?=
 =?us-ascii?Q?KQ7wDo7HLrsNblZmDHIZZ94fRxnr9oz6BqUIo6dpbMjnGUHCkk0izK5p3mln?=
 =?us-ascii?Q?k5hK12sHFMA7xAoWmA6se3fFXfxAfNbTlxhOWaapZRSDPs8cAO4Tw5ZnxnzR?=
 =?us-ascii?Q?p4MHkw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB5825.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8594f6fc-6ed7-43f8-cc97-08d9b81ad39e
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2021 18:12:40.6684
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5vcl0nZ8Tq5iKFdr3zG2iiAqYsBTT8/VW/8lCrFiBx+NI6a1oi99E6Ff1A1oBIczLbAIbSB7AIThobBsw2acTs/SOKlSw2gLKAQHZOVIN+M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4795
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] iwlwifi: mei: allow tracing to be disabled
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> The Makefile conditionally leaves out the trace implementation, but it ge=
ts
> called unconditionally:
>=20
> ERROR: modpost: "__SCT__tp_func_iwlmei_me_msg"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__tracepoint_iwlmei_me_msg"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__SCT__tp_func_iwlmei_sap_cmd"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__tracepoint_iwlmei_sap_cmd"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__SCT__tp_func_iwlmei_sap_data"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
> ERROR: modpost: "__tracepoint_iwlmei_sap_data"
> [drivers/net/wireless/intel/iwlwifi/mei/iwlmei.ko] undefined!
>=20
> Use the same macro incantation that is used in the main iwlwifi driver to
> leave out the tracing when CONFIG_IWLWIFI_DEVICE_TRACING is disabled.
>=20
> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation w=
ith
> CSME")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks for this, but Kalle just merged a fix I had already sent.
=20