Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF947C433FE for ; Sun, 5 Dec 2021 21:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239320AbhLEVL1 (ORCPT ); Sun, 5 Dec 2021 16:11:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239250AbhLEVLZ (ORCPT ); Sun, 5 Dec 2021 16:11:25 -0500 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8448C061714; Sun, 5 Dec 2021 13:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lwUO7B9IFC6cJheRa4VatEkY0oxyKYXIKpddYrNMofc=; b=FolUdYW39rQxjwC5tRDQxRQ51c VWFHqivr6fPYc/vLI5VdPJ+YUB/J5bJB7OlZanGKarAmU4pks3KHyjpNQ+6iK4dQBFVATpGJBKPj+ 3gGkCh7wV8b7Fvy0LuH8A9v/gbMWMSWA9hrnJaada5mGBx2Vf/uqDd9y+3JgBT4lxqoI=; Received: from p200300ccff4cbc001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff4c:bc00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1mtyjZ-00064v-PO; Sun, 05 Dec 2021 22:07:46 +0100 Date: Sun, 5 Dec 2021 22:07:44 +0100 From: Andreas Kemnade To: Alistair Francis Cc: kernel@pengutronix.de, robh+dt@kernel.org, lee.jones@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, alistair23@gmail.com, linux-hwmon@vger.kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rui.zhang@intel.com, linux-imx@nxp.com, devicetree@vger.kernel.org, amitk@kernel.org, shawnguo@kernel.org Subject: Re: [PATCH v16 8/8] ARM: dts: imx7d: remarkable2: Enable lcdif Message-ID: <20211205220744.18534b50@aktux> In-Reply-To: <20211202120758.41478-9-alistair@alistair23.me> References: <20211202120758.41478-1-alistair@alistair23.me> <20211202120758.41478-9-alistair@alistair23.me> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Dec 2021 22:07:58 +1000 Alistair Francis wrote: > Connect the dispaly on the reMarkable2. > > Signed-off-by: Alistair Francis > --- > arch/arm/boot/dts/imx7d-remarkable2.dts | 73 +++++++++++++++++++++++++ > 1 file changed, 73 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts > index b66d28b30d75..bb0c68d24583 100644 > --- a/arch/arm/boot/dts/imx7d-remarkable2.dts > +++ b/arch/arm/boot/dts/imx7d-remarkable2.dts [...] > @@ -187,6 +221,45 @@ MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f > >; > }; > > + pinctrl_lcdif: lcdifgrp { > + fsl,pins = < > + MX7D_PAD_LCD_DATA00__LCD_DATA0 0x79 > + MX7D_PAD_LCD_DATA01__LCD_DATA1 0x79 > + MX7D_PAD_LCD_DATA02__LCD_DATA2 0x79 > + MX7D_PAD_LCD_DATA03__LCD_DATA3 0x79 > + MX7D_PAD_LCD_DATA04__LCD_DATA4 0x79 > + MX7D_PAD_LCD_DATA05__LCD_DATA5 0x79 > + MX7D_PAD_LCD_DATA06__LCD_DATA6 0x79 > + MX7D_PAD_LCD_DATA07__LCD_DATA7 0x79 > + MX7D_PAD_LCD_DATA08__LCD_DATA8 0x79 > + MX7D_PAD_LCD_DATA09__LCD_DATA9 0x79 > + MX7D_PAD_LCD_DATA10__LCD_DATA10 0x79 > + MX7D_PAD_LCD_DATA11__LCD_DATA11 0x79 > + MX7D_PAD_LCD_DATA12__LCD_DATA12 0x79 > + MX7D_PAD_LCD_DATA13__LCD_DATA13 0x79 > + MX7D_PAD_LCD_DATA14__LCD_DATA14 0x79 > + MX7D_PAD_LCD_DATA15__LCD_DATA15 0x79 > + > + MX7D_PAD_LCD_DATA17__LCD_DATA17 0x79 > + MX7D_PAD_LCD_DATA18__LCD_DATA18 0x79 > + MX7D_PAD_LCD_DATA19__LCD_DATA19 0x79 > + MX7D_PAD_LCD_DATA20__LCD_DATA20 0x79 > + MX7D_PAD_LCD_DATA21__LCD_DATA21 0x79 > + > + MX7D_PAD_LCD_DATA23__LCD_DATA23 0x79 > + MX7D_PAD_LCD_CLK__LCD_CLK 0x79 > + MX7D_PAD_LCD_ENABLE__LCD_ENABLE 0x79 > + MX7D_PAD_LCD_VSYNC__LCD_VSYNC 0x79 > + MX7D_PAD_LCD_HSYNC__LCD_HSYNC 0x79 > + MX7D_PAD_LCD_RESET__LCD_RESET 0x79 > + >; > + }; shouldn't this belong into the upper list: > + > + fsl,pins = < > + MX7D_PAD_LCD_DATA22__GPIO3_IO27 0x74 > + >; > + }; > + probably some rebase or merge accident. If I submit non-trivial things, I usually apply my patches to a separate git tree and do a final compile, that might help to reduce some trouble. Regards, Andreas