From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Ameer Hamza <amhamza.mgc@gmail.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ASoC: test-component: fix null pointer dereference.
Thread-Topic: [PATCH] ASoC: test-component: fix null pointer dereference.
Thread-Index: AQHX6hiZRK5cTb56bk2m5NVbTZyjx6wkenEw
Date:   Sun, 5 Dec 2021 22:40:27 +0000
Message-ID: <TYCPR01MB55813B26BB2B3BB6D1E072F2D46C9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
References: <20211205204200.7852-1-amhamza.mgc@gmail.com>
In-Reply-To: <20211205204200.7852-1-amhamza.mgc@gmail.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5EjQ88F+vCfyiyHC4CsSB9RxfmxXh+Y7L6RLCfYftHanGjtfvTB34AFJaCvD?=
 =?us-ascii?Q?dauDJ4ZZLDFZNBTMt6W4SRKO5239qOIrkwAWXUeBFm4zdPVM9V/G0Df6K+Bc?=
 =?us-ascii?Q?IZeHVhkyIEN8nGgxOXw7xiCpTwFCCzYDUEbYyrollSD4x+gMEK7AGgkJSmJJ?=
 =?us-ascii?Q?GU92OfgiXDuygxxRoK5o/BQ1VlwD1Gc/KDk931YdmlDn7xTvgahNV5pSqqGi?=
 =?us-ascii?Q?MiWRR7riktanwSAnsGvKELpOTX127/swTSlpRe/a3E1MTb6kUy/00LvxYyXl?=
 =?us-ascii?Q?P6nAvrK1BaxTWF1O7Z/T9ftNB/6e1UIJ7btMWaA9LSjywSth5sIKxLf9LJDc?=
 =?us-ascii?Q?SoxNNHla6a5JhF+geiC2rB+5O0B3aaY30zjl3kQmG7kq0msguXTp+9NeLNlr?=
 =?us-ascii?Q?Cnpyb/zGm+FsqDYJh10TZFLO+6M6mykRDwgabxM4tclQmH5sX6TyidHuvE9f?=
 =?us-ascii?Q?J7lQ1hPmhlcv5vjPeiUATNANTDjd3YHR5XsBo67Igt7z7w1qMriHW6YEBrtY?=
 =?us-ascii?Q?3o/+JIIlstKbHD9fkJsV57eNz0aXROFfHsn8oQmInFjzbrqYX7N626Ax3+M4?=
 =?us-ascii?Q?Y2J0h+/o1uKFGv7Of4Of0Abe2i5HOQG368maBkKI7n5HXL2j42365pPPW0Vp?=
 =?us-ascii?Q?Y2/Z9DpLnG3e3WuxhxNtVLMiI5J+jaJr7BtmwThC7KLhBIZ5bWiciRKfkIZC?=
 =?us-ascii?Q?JuVZXDkW2onSJujy9BXqhgeQw7zomF63/zCxq19WoXb2RIQtxy5fEzF99XZQ?=
 =?us-ascii?Q?hXWzgYQzE0PuTPCsPUTbitNa/urxz6IFZDqoEqqiLLOX8jrTf+7UBFVbQspW?=
 =?us-ascii?Q?yuqjKKxgaMVajx8YA44lE16s22ZPKFM1UukU1Xfj+Y/bsxEbHvQpp+1N59V0?=
 =?us-ascii?Q?r6MLdlZsw4m+kfVWNwpSiAuzTX7S4MGphwzsinQaXFVY6fFfYmldfE+HR8K8?=
 =?us-ascii?Q?lB7jYmiFB2Z9WMR1ucfE3HiOfi2WNVNnUEKOO4Hy3SWr1Be8SoYsN3BaD1XN?=
 =?us-ascii?Q?zdGKd21gbAhZ/ihMmckAQSuGyx6DvfLpufRYqXhSN7nhJZzMFoUxso/qrIiP?=
 =?us-ascii?Q?Q+B5hjwmcWdvIQun7DF5hnaqKWke3IfSf70AJ3lYZTKNur12J0oh8JhdNihw?=
 =?us-ascii?Q?jzxKDd+BW0r84jgRr+PqoX7ldA3CAFSX+Xq7Q9zPbI7fYb5C/D86yy3ay/0y?=
 =?us-ascii?Q?beZtopKzqNPyhzexKOpJ8HoAYCmajkOg+HxrrgbAr5ZX+auU5W44EUak3H36?=
 =?us-ascii?Q?p2mSPf2ruvlOn8ZcvEX2aptqWJfXcdDpFSJwoWQSGC6jAT6OwJZ/esw//zFX?=
 =?us-ascii?Q?8kH6kwCEGWonh/kJbhC8DL2CG/vzjYzdqwO8fdPOB+kIXafn9v2OkCrLaXUl?=
 =?us-ascii?Q?jvIG1WwoXiExd08XQn1d4JE0cvvg1fJPujd05cpTJTlR2kMxe0YLJ15jZL/G?=
 =?us-ascii?Q?GWPlFpyx2tUULvKx+fA2mB405OFBFO3fp1v/owoleF6oPDOl+6g0bzBXkw0K?=
 =?us-ascii?Q?LLBB23T5PgbE+T5eBnsTYwT+NG4C5VlW+LxFBGsKru4KvstGO85sF/tRktWe?=
 =?us-ascii?Q?1xiuLj/bH8h880u5xee7294JEif7CQ+JTMqwindLkbkqtOJL+j158gkm+LfO?=
 =?us-ascii?Q?mXES6GgBSkzbS5tyagxSQzZhP9doAimJecfdYrhXb4lZGT/jbQG5Y4H7nGnR?=
 =?us-ascii?Q?yaWCxpgF68TgP8SlXfUYM3sdwsAHwlvg8o/v9UT6OGH5eQVP3SVHcQcso84b?=
 =?us-ascii?Q?bu9n2HWX7w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB5581.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4938372d-7ffe-4bff-0d64-08d9b8403c1c
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2021 22:40:27.4431
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DaOKFZJ6f2DBFi0uesJkGI8jd3uCClz1NbRqsfl/AJz+s3ryEBAzBN0D8wX0hsBVWVO1PTZeNVzvGjlH7rlkK0coz7BBv/VSBd4KyUCn2TrRWEz0fNaxtGYBggfdCI7V
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB6240
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Ameer

Thank you for your patch.

> Dereferncing of_id pointer will result in exception in current
> implementation since of_match_device() will assign it to NULL.
> Adding NULL check for protection.
(snip)
> @@ -532,13 +532,16 @@ static int test_driver_probe(struct platform_device=
 *pdev)
>  	struct device_node *node =3D dev->of_node;
>  	struct device_node *ep;
>  	const struct of_device_id *of_id =3D of_match_device(test_of_match, &pd=
ev->dev);
> -	const struct test_adata *adata =3D of_id->data;
> +	const struct test_adata *adata;
>  	struct snd_soc_component_driver *cdriv;
>  	struct snd_soc_dai_driver *ddriv;
>  	struct test_dai_name *dname;
>  	struct test_priv *priv;
>  	int num, ret, i;
> =20
> +	if (!of_id)
> +		return -EINVAL;
> +	adata =3D of_id->data;

But hmm...
Probing this driver without adata is strange for me.
How did probe this driver ??

Best regards
---
Kuninori Morimoto