Date:   Mon, 6 Dec 2021 11:39:29 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/7] Support for some TQMa8M* boards
Message-ID: <20211206033921.GF4216@dragon>
References: <20211201072949.53947-1-alexander.stein@ew.tq-group.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211201072949.53947-1-alexander.stein@ew.tq-group.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Dec 01, 2021 at 08:29:41AM +0100, Alexander Stein wrote:
> Thanks for the review on v2!
> 
> Changes in v3:
> * Rebased to next-20211129
> * Adjusted commit subjects (tree -> device tree)
> * Use hyphen in node names instead of underscore
> * Removed bootargs from DT
> * Fixed audio-codec node name and handle name
> * Property 'enet-phy-lane-no-swap' was already documented, but got accidently
>   removed during YAML conversion. Fix is pending at at [2]
> * Use matrix instead of array for 'fsl,pins' as required by pinctrl bindings.
>   This reduces the lines in stderr from dtbs_check for these DT files from 475
>   down to 191
> * Removed TODO regarding unsupported USB over-current polarity
> 
> Changes in v2:
> * Rebased to next-20211101
> * Added Rob's Acked-By on Patch for DT bindings
> * for other changes please refer to individual patches
> 
> Note on TQMa8Mx:
> Due to CPU errata cpuidle is broken and needs to be disabled, see [1] for
> pending patch.
> 
> This patch set adds support for the following modules:
> * TQMa8Mx
> * TQMa8MxML
> * TQMa8MxNL
> 
> Each of the modules is available with different i.MX8M variants, the
> bootloader modifies the device tree and disabled paripherals which
> are not available on the actual hardware.
> 
> All of them can be attached to the same mainboard MBa8Mx, although
> TQMa8MxML & TQMa8MxNL need an adapter. For that reason there is a single
> mainboard .dtsi file named mba8mx.dtsi.
> 
> There is a .dtsi file for each module named imx8m?-tmqa8m*.dts.
> 
> Finally there is the final .dts file which includes the mainboard and
> the attached module and contains the missing connection, prominently clk
> and pinctrl defines.
> 
> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20211105095535.3920998-1-alexander.stein@ew.tq-group.com/
> [2] https://www.spinics.net/lists/devicetree/msg460023.html
> 
> Alexander Stein (7):
>   dt-bindings: arm: fsl: add TQMa8MxML boards
>   arm64: dts: freescale: add initial device tree for TQMa8MQML with
>     i.MX8MM
>   arm64: defconfig: enable drivers for TQ TQMa8MxML-MBa8Mx
>   dt-bindings: arm: fsl: add TQMa8MxNL boards
>   arm64: dts: freescale: add initial device tree for TQMa8MQNL with
>     i.MX8MN
>   dt-bindings: arm: fsl: add TQMa8Mx boards
>   arm64: dts: freescale: add initial device tree for TQMa8Mx with i.MX8M

Applied all, thanks!