Date:   Mon, 6 Dec 2021 09:13:06 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Leo Yan <leo.yan@linaro.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jan Harkes <jaharkes@cs.cmu.edu>, coda@cs.cmu.edu,
        Paul Moore <paul@paul-moore.com>,
        Eric Paris <eparis@redhat.com>,
        Balbir Singh <bsingharora@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
        linux-arm-kernel@lists.infradead.org, codalist@coda.cs.cmu.edu,
        linux-audit@redhat.com
Subject: Re: [PATCH v1 1/7] pid: Introduce helper task_is_in_root_ns()
Message-ID: <Ya24AjNDpO+uuLMT@unreal>
References: <20211205145105.57824-1-leo.yan@linaro.org>
 <20211205145105.57824-2-leo.yan@linaro.org>
 <Ya2yXZAn+36yhfdU@unreal>
 <20211206070358.GC42658@leoy-ThinkPad-X240s>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206070358.GC42658@leoy-ThinkPad-X240s>
Precedence: bulk

On Mon, Dec 06, 2021 at 03:03:58PM +0800, Leo Yan wrote:
> Hi Leon,
> 
> On Mon, Dec 06, 2021 at 08:49:01AM +0200, Leon Romanovsky wrote:
> > On Sun, Dec 05, 2021 at 10:50:59PM +0800, Leo Yan wrote:
> 
> [...]
> 
> > > +static inline bool task_is_in_root_ns(struct task_struct *tsk)
> > 
> > It is bad that this name doesn't reflect PID nature of this namespace.
> > Won't it better to name it task_is_in_init_pid_ns()?
> 
> Yes, task_is_in_init_pid_ns() is more clear.
> 
> Will respin for this.  Thank you for suggestion!

Thanks

> 
> Leo