Subject: Re: [RFC PATCH] watchdog: da9062: Correct the timeout values
To:     Christoph Niedermaier <cniedermaier@dh-electronics.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Cc:     Support Opensource <support.opensource@diasemi.com>,
        Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Guenter Roeck <linux@roeck-us.net>
References: <20211203163539.91870-1-cniedermaier@dh-electronics.com>
 <dc6a432c-79a3-881c-eac4-32620040d11b@roeck-us.net>
 <4bfb6ab512cd45ee81c55361525987b7@dh-electronics.com>
From:   Andrej Picej <andrej.picej@norik.com>
Message-ID: <a0b6a801-f911-3371-1067-479b66240bdc@norik.com>
Date:   Mon, 6 Dec 2021 08:29:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <4bfb6ab512cd45ee81c55361525987b7@dh-electronics.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3. 12. 21 18:31, Christoph Niedermaier wrote:
> From: Guenter Roeck
> Sent: Friday, December 3, 2021 5:52 PM
>> On 12/3/21 8:35 AM, Christoph Niedermaier wrote:
>>> I measured the timeout values of my DA9061 chip. According to the
>>> information in the data sheet the formula should be:
>>>
>>> timeout = 2.048 * 2^(regval - 1)
>>>
>>> But my measured values differ from that.
>>> Accoring to my measured values the formula must be:
>>>
>>> timeout = 3.2 * 2^(regval - 1)
>>>
>>> Is there something wrong with my chip, or has anyone else noticed this as well?
>>
>> The driver assumes a static and well defined clock rate. Maybe that rate
>> is different in your system (if that is possible) ?
>>
>> Guenter
> 
> @Andrej
> Do the values in the driver match what your chip does?
> 

Just did a quick test. The values in the driver match what the chip 
does. I checked multiple timeouts 16, 32, 65 and 131 seconds. The 
timeout triggers quite accurately.

> I have not changed anything. After power on, the chip behaves like this.
> So I guess it either come from an OTP value or the wiring outside the chip.
> Does anyone know what needs to be checked?

Can't help you here, sorry.

Best regards,
Andrej