MIME-Version: 1.0
References: <20211203185928.821497-1-arnd@kernel.org>
In-Reply-To: <20211203185928.821497-1-arnd@kernel.org>
From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Mon, 6 Dec 2021 08:44:56 +0100
Message-ID: <CAO-hwJLsijqibqARiWP0tPnmSDnrPsxSXDsvkgTV0=R7kQ1oOQ@mail.gmail.com>
Subject: Re: [PATCH] HID: prodikeys: add USB_HID dependency
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Jiri Kosina <jikos@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        "Daniel J. Ogorchock" <djogorchock@gmail.com>,
        =?UTF-8?B?QmFybmFiw6FzIFDFkWN6ZQ==?= <pobrn@protonmail.com>,
        Roderick Colenbrander <roderick.colenbrander@sony.com>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Arnd,

On Fri, Dec 3, 2021 at 8:07 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Like with the other drivers that recently got fixed, this one
> fails to link if USB_HID is disabled or unreachable:
>
> ERROR: modpost: "usb_hid_driver" [drivers/hid/hid-prodikeys.ko] undefined!
>
> Fixes: f237d9028f84 ("HID: add USB_HID dependancy on some USB HID drivers")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Looks like you already been beaten to it by Greg:
https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-5.16/upstream-fixes&id=30cb3c2ad24b66fb7639a6d1f4390c74d6e68f94

But thanks!

Cheers,
Benjamin

>  drivers/hid/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 74ce789f8636..48d18559670f 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -246,7 +246,7 @@ config HID_MACALLY
>
>  config HID_PRODIKEYS
>         tristate "Prodikeys PC-MIDI Keyboard support"
> -       depends on HID && SND
> +       depends on USB_HID && SND
>         select SND_RAWMIDI
>         help
>         Support for Prodikeys PC-MIDI Keyboard device support.
> --
> 2.29.2
>