MIME-Version: 1.0
Date:   Mon, 06 Dec 2021 09:13:27 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From:   yajun.deng@linux.dev
Message-ID: <0a2496c3503ba85205a5da0d8e61ea78@linux.dev>
Subject: Re: [PATCH] completion: introduce complete_put() helper function
To:     "Peter Zijlstra" <peterz@infradead.org>
Cc:     mingo@redhat.com, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, linux-kernel@vger.kernel.org
In-Reply-To: <Ya3LFV2W05TZzMnC@hirez.programming.kicks-ass.net>
References: <Ya3LFV2W05TZzMnC@hirez.programming.kicks-ass.net>
 <20211206040319.7063-1-yajun.deng@linux.dev>
Precedence: bulk

December 6, 2021 4:34 PM, "Peter Zijlstra" <peterz@infradead.org> wrote:=
=0A=0A> On Mon, Dec 06, 2021 at 12:03:19PM +0800, Yajun Deng wrote:=0A> =
=0A>> There are many cases where it is necessary to decrease refcount and=
 test,=0A>> then called complete(). So introduce complete_put() helper fu=
nction.=0A>> =0A>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>=0A>> =
---=0A>> kernel/sched/completion.c | 7 +++++++=0A>> 1 file changed, 7 ins=
ertions(+)=0A>> =0A>> diff --git a/kernel/sched/completion.c b/kernel/sch=
ed/completion.c=0A>> index a778554f9dad..dcb737f1edc2 100644=0A>> --- a/k=
ernel/sched/completion.c=0A>> +++ b/kernel/sched/completion.c=0A>> @@ -38=
,6 +38,13 @@ void complete(struct completion *x)=0A>> }=0A>> EXPORT_SYMBO=
L(complete);=0A>> =0A>> +void complete_put(refcount_t *r, struct completi=
on *x)=0A>> +{=0A>> + if (refcount_dec_and_test(r))=0A>> + complete(x);=
=0A>> +}=0A>> +EXPORT_SYMBOL(complete_put);=0A> =0A> Please submit such t=
hings as part of the series that makes use of them.=0A=0AHere is a typica=
l use case=EF=BC=9A       vim drivers/infiniband/core/device.c +101=0Asta=
tic void ib_client_put(struct ib_client *client)=0A{=0A        if (refcou=
nt_dec_and_test(&client->uses))=0A                complete(&client->uses_=
zero);=0A}=0A=0AEach driver needs to define a xxx_put() function if they =
want to use it, we can add this helper function for them.