From:   Philippe Schenker <philippe.schenker@toradex.com>
To:     netdev@vger.kernel.org, Joakim Zhang <qiangqing.zhang@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Fugang Duan <fugang.duan@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>
Cc:     Philippe Schenker <philippe.schenker@toradex.com>,
        linux-kernel@vger.kernel.org
Subject: [RFC PATCH 2/2] net: fec: reset phy in resume if it was powered down
Date:   Mon,  6 Dec 2021 11:13:26 +0100
Message-Id: <20211206101326.1022527-3-philippe.schenker@toradex.com>
In-Reply-To: <20211206101326.1022527-1-philippe.schenker@toradex.com>
References: <20211206101326.1022527-1-philippe.schenker@toradex.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y+ONAH17lXQpkHywhNGMjhIZQRXm50+IBcBF75oNa+fNExUq7LT6T9/7GPR8?=
 =?us-ascii?Q?CuXX/qQYHJp8OdtVQZkz/+McDRUGcaimXT2fxK3oioDUevGnBLtTi7vr4pei?=
 =?us-ascii?Q?Ws6/DRx0altqFWGqBiISP3Y9eCXLKKTPuF/Ni35xNx5EmSHRyjZ1wf+BbCSG?=
 =?us-ascii?Q?yXvplfDkQsoHIg56/jdVPNsTr/dDzZzmSQD8vI0fjTl4rl3KYbCvc8mPC/ne?=
 =?us-ascii?Q?Jx+8sq3i6g8w6C2IEE8tCidgn9bUhV9h7SsTEyR4GkHdO0vgN3lJZrkxiptq?=
 =?us-ascii?Q?UaaYHuhJq1rnwEbC5hj8gtbc4AMge8YHpOhhxNjFJ1nDpUxrbj4LjlwrpXe2?=
 =?us-ascii?Q?PxGDR+5P0cAzgG5Miv6Cko6JUyZZAhquvuRMcSL+oWrJ5ypwaI/vEdcOT01U?=
 =?us-ascii?Q?ngQz43O2hLaJcP8BDt9oGpyo/jo7f4h29z7FjLKq9+WM9A0xvtdTOCIjHoQL?=
 =?us-ascii?Q?RL9QjcknQVqduLpm9iNV4fAgw6i/AJ1+nawUmKXkM+vGU3TjOGh+ehzsUuqj?=
 =?us-ascii?Q?2zvwymvJDThhzDrWWSrQCofl8KD1uBLeCP+JrErZ+iFeY/t9UQYHYOG3bidU?=
 =?us-ascii?Q?hznE0Pzcr2CHQ3gXhKUD4Z0Apxpi6V5js3wqIDztfBRkx12Ci7QU1/co+FGO?=
 =?us-ascii?Q?6TIWK8XXgt7wtxPyIdMQXGIPxIezQuO+V7s2YFAyltxUghH58tiB2jAqH8fL?=
 =?us-ascii?Q?OVLenrO/iIWCkcihZC95WhQhOR5vmgW4aCw29xlBh9T/PIXCL9p5WUr/5TCK?=
 =?us-ascii?Q?YndLAXu2WngTB6vAWnvLOjsxT59uYtNBB6Pi+9SGuhPCbfdaOfaUvq70Jn0M?=
 =?us-ascii?Q?mRCdD1uM6f+nfZ2OhXak+g3340mpUlrXGYLbP3mcBk6UEDRbCp2ZXU0aygn4?=
 =?us-ascii?Q?Asa6yumWs+qctEwXEzfIle+r1/TmooxJfRzNQ5ekvgqwtqVolvoFr106OvlT?=
 =?us-ascii?Q?5kGG1/eoUPI53A92Au5nV/ElmN6vLM+MNOd9UGgpXtreWd7AtKBpZQvSwOcx?=
 =?us-ascii?Q?PxkQpcxT/BnY4M8Qeh0/04ohGiBItP6GpLv/34D9IbhoEb3lts1VxG+7wrdZ?=
 =?us-ascii?Q?kwCHjWpPC91BFGEnarkwQhXAAt4a8mYzC/96/GwOggA5ZO7h31IjQyTgLYka?=
 =?us-ascii?Q?woRKtGOZiGjMQbD/4lv9MmEcDbbSyeSq+BdWShxcCToQYh7LYxepWBH2HiMZ?=
 =?us-ascii?Q?NhqpdH89RoKo15qsRyJ5o+TVSjoV0nvD3HDIvopxAyrWHHwQM0WKZAQx4A5u?=
 =?us-ascii?Q?X+se56jfGJcWrvy6konnsaep2nQCqKIUtdnxyEWreUd9Gms5JJfhqvc7yH0T?=
 =?us-ascii?Q?U5r33/KFkVDYZTCdAH2kxzOVxMKrSjJNC4DO895KDx5plIV9EU5uSeNbu7WK?=
 =?us-ascii?Q?Z7aUHT7DDzvelpGUMibBPXv5vDFtqNYOIdu/kTV/dhXyxzI5+u7ztKjC6wT1?=
 =?us-ascii?Q?QH1Eyztqy+FZlkBP0VRWDPRJychXQgKh/dcjwp3XkOQc5m8OGrXh8UjhUurf?=
 =?us-ascii?Q?GS+hJM9ApuCbSXYLPlMdn31M8CJPqbsXNZ6+QGY4PPDubptq1CHdDvhnsYe5?=
 =?us-ascii?Q?og7s/2lg4/4laVjblybuMxiqIYCK43KAvIX0cZkM/SUq977yUYJHtfVEiSoN?=
 =?us-ascii?Q?Z/4CCgiNv9fBO8CGFyV/xHyFDjCZX6jIfikc/eOlHBEof46APirixDqru+8L?=
 =?us-ascii?Q?aXb8VQ=3D=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9123f02b-d50c-4281-83cf-08d9b8a11b13
X-MS-Exchange-CrossTenant-AuthSource: ZR0P278MB0377.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 10:13:53.4250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8kNmt8sfp0pTjsqC1PuWUjPUMUNPLsrJdw4Cjij9ci2VAyqNUL5eWwNyYkQlC6WszeKVOMxxpZUbZJ/81ivjntfe/ZfzxxDf7nQVFo4swwc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZRAP278MB0206
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If a board solely rely on a GPIO to reset the PHY after power-up, the
PHY won't work after a power-down where the power was cut.

Reset the PHY after power-enable in fec_resume.

Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

---

 drivers/net/ethernet/freescale/fec_main.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 92840f18c48f..41c3825cd768 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4118,6 +4118,10 @@ static int __maybe_unused fec_resume(struct device *dev)
 		ret = regulator_enable(fep->reg_phy);
 		if (ret)
 			return ret;
+
+		ret = fec_reset_phy(ndev);
+		if (ret)
+			return ret;
 	}
 
 	rtnl_lock();
-- 
2.34.0