Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB7FC4332F for ; Mon, 6 Dec 2021 11:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242788AbhLFMAF (ORCPT ); Mon, 6 Dec 2021 07:00:05 -0500 Received: from 8bytes.org ([81.169.241.247]:40126 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242778AbhLFL77 (ORCPT ); Mon, 6 Dec 2021 06:59:59 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 341393FC; Mon, 6 Dec 2021 12:56:28 +0100 (CET) Date: Mon, 6 Dec 2021 12:56:21 +0100 From: Joerg Roedel To: Yicong Yang Cc: gregkh@linuxfoundation.org, helgaas@kernel.org, alexander.shishkin@linux.intel.com, lorenzo.pieralisi@arm.com, will@kernel.org, mark.rutland@arm.com, mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, jonathan.cameron@huawei.com, daniel.thompson@linaro.org, john.garry@huawei.com, shameerali.kolothum.thodi@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-pci@vger.kernel.org, linux-perf-users@vger.kernel.org, iommu@lists.linux-foundation.org, prime.zeng@huawei.com, liuqi115@huawei.com, zhangshaokun@hisilicon.com, linuxarm@huawei.com, song.bao.hua@hisilicon.com Subject: Re: [PATCH v2 1/6] iommu: Export iommu_{get,put}_resv_regions() Message-ID: References: <20211116090625.53702-1-yangyicong@hisilicon.com> <20211116090625.53702-2-yangyicong@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211116090625.53702-2-yangyicong@hisilicon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 16, 2021 at 05:06:20PM +0800, Yicong Yang wrote: > Export iommu_{get,put}_resv_regions() to the modules so that the driver > can retrieve and use the reserved regions of the device. Why should any driver bother? These functions are only used by the iommu core to call into iommu drivers to get information about needed direct mappings. Why drivers need this information belongs into this commit message. Regards, Joerg