Date:   Mon, 6 Dec 2021 14:32:37 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Apeksha Gupta <apeksha.gupta@nxp.com>
Cc:     qiangqing.zhang@nxp.com, netdev@vger.kernel.org, kuba@kernel.org,
        arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-devel@linux.nxdi.nxp.com, LnxRevLi@nxp.com,
        sachin.saxena@nxp.com, hemant.agrawal@nxp.com
Subject: Re: [PATCH v2 0/3] drivers/net: split FEC driver
Message-ID: <Ya4Q9aysfYwV35MO@lunn.ch>
References: <20211206045536.8690-1-apeksha.gupta@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211206045536.8690-1-apeksha.gupta@nxp.com>
Precedence: bulk

On Mon, Dec 06, 2021 at 10:25:33AM +0530, Apeksha Gupta wrote:
> This patch series is to restructure the FEC (Fast Ethernet Controller)
> driver. All PHY functionality moved from fec_main.c to separate files
> fec_phy.h and fec_phy.c. By these changes FEC driver become more
> flexible to work with other PHY drivers whenever required in future.

The MAC driver has little to do with the PHY driver. All PHY driver
details are in the actual PHY driver and phylib. At minimum we need to
see these other PHY driver changes, so you can justify this change.

What i think you are trying to do is sneak in the changes you need for
DPDK. Please don't so that. Just implement XDP.

NACK

      Andrew