Date:   Mon, 6 Dec 2021 13:47:31 +0000
From:   Mark Brown <broonie@kernel.org>
To:     "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>, swboyd@chromium.org,
        collinsd@codeaurora.org, subbaram@codeaurora.org,
        Das Srinagesh <gurus@codeaurora.org>,
        linux-arm-msm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/6] dt-bindings: regulator: Add pm8008 regulator
 bindings
Message-ID: <Ya4UcxxEq9t+isxS@sirena.org.uk>
References: <1637314953-4215-1-git-send-email-quic_c_skakit@quicinc.com>
 <1637314953-4215-3-git-send-email-quic_c_skakit@quicinc.com>
 <YZ+qn2hA4MzNEqM+@sirena.org.uk>
 <30b21a08-f7f7-f3a6-a3ac-156c7f8964b1@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="s2Y/onyCi0oqM7Zy"
Content-Disposition: inline
In-Reply-To: <30b21a08-f7f7-f3a6-a3ac-156c7f8964b1@quicinc.com>
Precedence: bulk


--s2Y/onyCi0oqM7Zy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 06, 2021 at 07:13:02PM +0530, Satya Priya Kakitapalli (Temp) wr=
ote:
>=20
> On 11/25/2021 8:54 PM, Mark Brown wrote:
> > On Fri, Nov 19, 2021 at 03:12:29PM +0530, Satya Priya wrote:

> > > +properties:
> > > +  compatible:
> > > +    const: qcom,pm8008-regulators
> > Why are we adding a separate compatible for this when we already know
> > that this is a pm8008 based on the parent?

> For the regulator driver to be probed we do need a separate compatible
> right? may be I didn't get your question..

> My understanding is we should have a separate compatible for each periphe=
ral
> under the parent mfd node.. like gpios, temp alarm, regulators etc..

No, the MFD can register whatever children it likes without needing any
help from the DT.

> > > +  vdd_l1_l2-supply:
> > > +    description: Input supply phandle of ldo1 and ldo2 regulators.

> > These supply nodes should be chip level, they're going into the chip and
> > in general the expectation is that you should be able to describe the
> > supplies going into a device without worrying about how or if any
> > particular OS splits things up.

> So, if i understand correctly, we don't have to mention these in the
> documentation as these are handled at framework level?

No.  I'm saying you should document these at the chip level, they do
need to be documented though.

--s2Y/onyCi0oqM7Zy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGuFHIACgkQJNaLcl1U
h9Bh+Qf8DxGyOs3yJmQBLpsw7yd/avRnEQw0x5C0ke/0N3cOZMaLc+Rm3NGu3u7f
DSxkpUYrbUdUy5AQLcsAFwVEF0rbEvi0QbXSbkYPxh4V/0sF5EF+dx6M6Rf7+fOY
BWTs9A83UkUUaY3jkhyjKcF2fhz2uFfMTm9p20XECVX+MHEslddV0DprWo6AWVPY
CtHx3z6ImfXWuMSIBWMo+KvtBi1Ywaw7Z6xYrY5MeSFM9RPiFYLCJVuQEWm0a4Zs
rLhh74SRXi/3670xcy/DiDyflKvfePtmlAXTFyKDyKnN6GBCv215KR8EtudIw0ZM
O8jUDRCSyVMn78Cx5FGhBPJxKJfvPg==
=+A0G
-----END PGP SIGNATURE-----

--s2Y/onyCi0oqM7Zy--