Date:   Mon, 6 Dec 2021 16:01:51 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Dongliang Mu <mudongliangabcd@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Irina Tirdea <irina.tirdea@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] driver: pmc_atom: free pmc->regmap when
 pmc_setup_clks fails
Message-ID: <Ya4XzxXomi1mCJ8R@smile.fi.intel.com>
References: <20211205084419.2382395-1-mudongliangabcd@gmail.com>
 <Ya4XbbVnK/0Getmt@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ya4XbbVnK/0Getmt@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Dec 06, 2021 at 04:00:13PM +0200, Andy Shevchenko wrote:
> On Sun, Dec 05, 2021 at 04:44:19PM +0800, Dongliang Mu wrote:
> > Smatch reports:
> > 
> > drivers/platform/x86/pmc_atom.c:496
> > pmc_setup_dev() warn: 'pmc->regmap' not released on lines: 496.
> > 
> > Fix this by deallocating pm->regmap when pmc_setup_clks fails.
> > 
> > Fixes: 282a4e4ce5f9("platform/x86: Enable Atom PMC platform clocks")
> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > ---
> 
> It says v2 in the subject, what is in v2 exactly in comparison to v1?
> 
> ...
> 
> >  	ret = pmc_setup_clks(pdev, pmc->regmap, data);
> > -	if (ret)
> > +	if (ret) {
> > +		iounmap(pmc->regmap);
> >  		dev_warn(&pdev->dev, "platform clocks register failed: %d\n",
> >  			 ret);
> 
> In this case it makes sense to move to
> 
> 		dev_err(&pdev->dev, "platform clocks register failed: %d\n", ret);
> 
> > +	}

Also, what about cleaning up debugfs?

-- 
With Best Regards,
Andy Shevchenko