MIME-Version: 1.0
References: <20211205084419.2382395-1-mudongliangabcd@gmail.com> <Ya4XbbVnK/0Getmt@smile.fi.intel.com>
In-Reply-To: <Ya4XbbVnK/0Getmt@smile.fi.intel.com>
From:   Dongliang Mu <mudongliangabcd@gmail.com>
Date:   Mon, 6 Dec 2021 22:09:58 +0800
Message-ID: <CAD-N9QVhB=C6nKHw4AjfMvZuOA8cGjuYv58nEDwy4eeF-2-iUw@mail.gmail.com>
Subject: Re: [PATCH v2] driver: pmc_atom: free pmc->regmap when pmc_setup_clks fails
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Irina Tirdea <irina.tirdea@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        platform-driver-x86@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Dec 6, 2021 at 10:01 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Sun, Dec 05, 2021 at 04:44:19PM +0800, Dongliang Mu wrote:
> > Smatch reports:
> >
> > drivers/platform/x86/pmc_atom.c:496
> > pmc_setup_dev() warn: 'pmc->regmap' not released on lines: 496.
> >
> > Fix this by deallocating pm->regmap when pmc_setup_clks fails.
> >
> > Fixes: 282a4e4ce5f9("platform/x86: Enable Atom PMC platform clocks")
> > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> > ---
>
> It says v2 in the subject, what is in v2 exactly in comparison to v1?

Sorry to forget to add this information

v1->v2: move iounmap(pmc->regmap); from success path to the error handling code.

>
> ...
>
> >       ret = pmc_setup_clks(pdev, pmc->regmap, data);
> > -     if (ret)
> > +     if (ret) {
> > +             iounmap(pmc->regmap);
> >               dev_warn(&pdev->dev, "platform clocks register failed: %d\n",
> >                        ret);
>
> In this case it makes sense to move to
>
>                 dev_err(&pdev->dev, "platform clocks register failed: %d\n", ret);
>
> > +     }
>
> --
> With Best Regards,
> Andy Shevchenko
>
>